From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbcHQAbp (ORCPT ); Tue, 16 Aug 2016 20:31:45 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51249 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcHQAbm (ORCPT ); Tue, 16 Aug 2016 20:31:42 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79cb6d000006cfe-36-57b3b06cfa4f Content-transfer-encoding: 8BIT Message-id: <57B3B06C.1040109@samsung.com> Date: Wed, 17 Aug 2016 09:31:40 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de, myungjoo.ham@samsung.com Cc: tixy@linaro.org, mark.rutland@arm.com, typ@rock-chips.com, linux-rockchip@lists.infradead.org, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, kyungmin.park@samsung.com, sudeep.holla@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com Subject: Re: [PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller References: <1471386989-9541-1-git-send-email-hl@rock-chips.com> <1471386989-9541-5-git-send-email-hl@rock-chips.com> In-reply-to: <1471386989-9541-5-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42JZI2JSqJuzYXO4Qe8qA4vecyeZLF5t3sNm cXbZQTaLK1/fs1n8f/Sa1eLHhlPMFmeb3rBbbHp8jdXi8q45bBafe48wWnx68J/ZYun1i0wW O6YcYLK4eMrV4nbjCjaLH2e6WSyWn9rBYrFw/n12i9mr6xyEPdbMW8Po8f5GK7vH7IaLLB6X +3qZPO5c28Pmsf3bA1aP+93HmTw2L6n3+DtrP4tH35ZVjB7br81j9vi8SS6AJ4rLJiU1J7Ms tUjfLoEr40XPBpaCD7wVp/bqNjB2cXcxcnJICJhIrHz7igXCFpO4cG89WxcjF4eQwApGie1r PzF3MXKAFe0F6gCLL2WUeHJwBzNIA6+AoMSPyfdYQGqYBeQljlzKBgkzC6hLTJq3iBmi/gGj xPr+C4wgNbwCWhKPWrhAalgEVCVOT+wC28sGFN7/4gYbiM0voChx9cdjsHJRgQiJ7hOVIGER AR+JrftOg53GLLCEWeLiu1/sIDXCAnESu9dVQKw6zSjxY99URpAGTgFHiUNrTjFB/PWCQ2Lj ZFmIvQIS3yYfYoF4S1Zi0wFmiBJJiYMrbrBMYBSfheSxWQiPzULy2AJG5lWMoqkFyQXFSelF RnrFibnFpXnpesn5uZsYgcnj9L9nfTsYbx6wPsQowMGoxMM7Y8bmcCHWxLLiytxDjKZAR0xk lhJNzgemqLySeENjMyMLUxNTYyNzSzMlcd4EqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODil Ghg5Hy+6k3I+gLv3+DP244ZW89UaFz4pkLQW9anSlv013+eJdlj//2WcrL4tkSrvBKbNzVW+ bLKzp39vBdcbZsWXi2dvLZlv8/almS7/zaSmBTMC34a31MntrYy9OMHjwu+FfjXdxu0b971d 8ihtmn9dJuNH7mg1PxXFvHupW7N4Z68048i4H6nEUpyRaKjFXFScCADHs9oSGQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCKsWRmVeSWpSXmKPExsVy+t9jAd2cDZvDDdZ1aVr0njvJZPFq8x42 i7PLDrJZXPn6ns3i/6PXrBY/Npxitjjb9IbdYtPja6wWl3fNYbP43HuE0eLTg//MFkuvX2Sy 2DHlAJPFxVOuFrcbV7BZ/DjTzWKx/NQOFouF8++zW8xeXecg7LFm3hpGj/c3Wtk9ZjdcZPG4 3NfL5HHn2h42j+3fHrB63O8+zuSxeUm9x99Z+1k8+rasYvTYfm0es8fnTXIBPFENjDYZqYkp qUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QD8qKZQl5pQChQIS i4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDNe9GxgKfjAW3Fqr24DYxd3FyMHh4SAicRe IIeRE8gUk7hwbz1bFyMXh5DAUkaJJwd3MIMkeAUEJX5MvscCUs8sIC9x5FI2SJhZQF1i0rxF zBD1Dxgl1vdfYASp4RXQknjUwgVSwyKgKnF6YhcLiM0GFN7/4gYbiM0voChx9cdjsHJRgQiJ 7hOVIGERAR+JrftOg53ALLCEWeLiu1/sIDXCAnESu9dVQKw6zSjxY99UsJs5BRwlDq05xTSB UXAWkktnIVw6C8mlCxiZVzFKpBYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIEp6hn0jsYD+9y P8QowMGoxMN7w2pzuBBrYllxZe4hRgkOZiURXpM1QCHelMTKqtSi/Pii0pzU4kOMpkC/TmSW Ek3OB6bPvJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1MPJ9n7s+ Xy92k6bGu09Ja8peffqhcuabU72HeesCGe0/nuySvLs87rN6szGlNMUZ7HwpmFJWdpFJkmmD Z9Xtor9/DIvWcN9qnTe9XKl297Ilor8kbCf9k/yRZGXUc+/owxcnVh4x5tGQS15qI7laPClO 5J2LyrXKlGybl/c3mJQqnlksW2xRocRSnJFoqMVcVJwIAEXxDIlnAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, I add one minor comment. After fixing it, looks good to me. Acked-by: Chanwoo Choi On 2016년 08월 17일 07:36, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v6: > -None > > Changes in v5: > -None > > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > -None > > Changes in v1: > -None > > .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..bf42255 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,20 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi@0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + Remove the blank line. Thanks, Chanwoo Choi