From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753386AbcHQBNd (ORCPT ); Tue, 16 Aug 2016 21:13:33 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36744 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcHQBNb (ORCPT ); Tue, 16 Aug 2016 21:13:31 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79cb6d000006cfe-bc-57b3b2b62c73 Content-transfer-encoding: 8BIT Message-id: <57B3B2B6.3020201@samsung.com> Date: Wed, 17 Aug 2016 09:41:26 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de, myungjoo.ham@samsung.com Cc: tixy@linaro.org, mark.rutland@arm.com, typ@rock-chips.com, linux-rockchip@lists.infradead.org, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, kyungmin.park@samsung.com, sudeep.holla@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com Subject: Re: [PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller References: <1471386989-9541-1-git-send-email-hl@rock-chips.com> <1471386989-9541-5-git-send-email-hl@rock-chips.com> <57B3B06C.1040109@samsung.com> In-reply-to: <57B3B06C.1040109@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTYRzl2727u1tan1Pza6CSIILia76+KKUk4ULSAyGjIF3zpuY2bVPT EFuGEI6ZopDNZ+Bj6CibppKSz8jmg9QyxXxniFpCkljkbHOE/Xc45/x+v3PgRxPCfK6ITlak s0qFROZBCUiDU/Bt3zZjS2xAq9oPa0ffcfBaSxeFR+p7Kfzh5yaF95bWuXin2UTgkbwNHjYu T3LxxKsKCm9pBwD+sbBH4LpPYxzcUdrDwWOmKDxzX0/hnWENiRtMHSR+Wj3Pw+VNuacdGUOV ATCbU/k8plw9RjIThVoO83myi2Latxe4zLzmLYdpqb3H7Oq6SaawtREw7ZNVBLNldLtod1Vw KoGVJWeySv+IeEGSeVaatguzip9kqMGofQHg0wgGo+ruFZ4NH0Xv555TBUBAC6EeIKPuBe+f qaHJTNqEOoCmtRMcq2APHdBOyZxFoGkCuqOB8RQb9EKlpXKbfQGgwbZ2ns3ujYqW5/dHSeiJ mpdGCCumLHz36hRlxUfgcfRxZxlY9zjDK0gzmG2lnWA0evl6aD8bAWsJNPb9N8/qcYTXUeez LNutDYDM9Q/3Z/nQB33bI6w8gl9otLnUSNruQrRd0rcfGUFXZOwhbBWPoV79FFkEXHT/FdMd FNMdFKsBRCNwZtOkaaobiUqxn0oiV2UoEv2kqXIjsHzHkPlrYQeY7jnZByANPOzsy8paYoVc SaYqW94HQiwZigmRszTV8lCK9LjAoFAxDgkOCRKHnQj1cLGPF/2KEcJESTqbwrJprDJOmSFj VX2AQ/NFaiD0dldGSn0Wa0zhd5ouXdOkjjx45BlwU58TXSF2+1OYk9A9VxWt0S7yZ2Kkh/TG Thl/NTMi37PebjjXHJYUZHcrXBLVudmRh5VnL1R29t/VwPXx/HN+59dWyuDsmUgv//DtNwm+ UrFPUaVhlNrGQvnursHx8WHX+Mu6foe4WA9SlSQJ9CaUKslfWoAFIxgDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEKsWRmVeSWpSXmKPExsVy+t9jAd1tmzaHG7TfVLPoPXeSyeLV5j1s FmeXHWSzuPL1PZvF/0evWS1+bDjFbHG26Q27xabH11gtLu+aw2bxufcIo8WnB/+ZLZZev8hk sWPKASaLi6dcLW43rmCz+HGmm8Vi+akdLBYL599nt5i9us5B2GPNvDWMHu9vtLJ7zG64yOJx ua+XyePOtT1sHtu/PWD1uN99nMlj85J6j7+z9rN49G1Zxeix/do8Zo/Pm+QCeKIaGG0yUhNT UosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgH5UUihLzCkFCgUk Fhcr6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGb8u5tc8FegYuLM0gbGc7xdjJwcEgImEstX /2OBsMUkLtxbz9bFyMUhJLCUUeJm72UmkASvgKDEj8n3gIo4OJgF5CWOXMqGMNUlpkzJhSh/ wChxYtt2dohyLYkJj++DtbIIqEpseHSWGcRmA4rvf3GDDcTmF1CUuPrjMSPIHFGBCInuE5Ug YREBH4mt+06DncAssIRZ4uK7X+wgNcICcRK711VA7HrDKPFvWQdYL6eAtsTb/8wTGAVnITl0 FsKhsxAOXcDIvIpRIrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOD09k97BeHiX+yFGAQ5G JR7eG1abw4VYE8uKK3MPMUpwMCuJ8L7cABTiTUmsrEotyo8vKs1JLT7EaAr06URmKdHkfGDq zCuJNzQ2MTOyNDI3tDAyNlcS5338f12YkEB6YklqdmpqQWoRTB8TB6dUA6N80bmAzHThzJR7 T/xULuUn3TXo3VF6bsOCY1IbN55lZHnq9G1XvtHuf4kLp/57lvhiX7dfe+AHldS9fIe1P7mJ WzF+nTBZaHH73GnaEnKlZR9j36VozDdy/vBlofYal8OhqolW8woXGfsvVpcq+5Eucrvim8zU WUFBT2dNYpLefZi9kd803k+JpTgj0VCLuag4EQBDO9bsZQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, I add the additional comment. On 2016년 08월 17일 09:31, Chanwoo Choi wrote: > Hi Lin, > > I add one minor comment. > > After fixing it, looks good to me. > Acked-by: Chanwoo Choi > > On 2016년 08월 17일 07:36, Lin Huang wrote: >> This patch adds the documentation for rockchip dfi devfreq-event driver. >> >> Signed-off-by: Lin Huang >> --- >> Changes in v6: >> -None >> >> Changes in v5: >> -None >> >> Changes in v4: >> -None >> >> Changes in v3: >> -None >> >> Changes in v2: >> -None >> >> Changes in v1: >> -None >> >> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt >> >> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt >> new file mode 100644 >> index 0000000..bf42255 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt >> @@ -0,0 +1,20 @@ >> + >> +* Rockchip rk3399 DFI device >> + >> +Required properties: >> +- compatible: Must be "rockchip,rk3399-dfi". >> +- reg: physical base address of each DFI and length of memory mapped region >> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" >> +- clocks: phandles for clock specified in "clock-names" property >> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; >> + >> +Example: >> + dfi: dfi@0xff630000 { >> + reg = <0x00 0xff630000 0x00 0x4000>; >> + compatible = "rockchip,rk3399-dfi"; As I said on previous mail-thread, the 'compatible' property is first usually. You better to change the order as following: compatible = "rockchip,rk3399-dfi"; reg = <0x00 0xff630000 0x00 0x4000>; >> + rockchip,pmu = <&pmugrf>; >> + clocks = <&cru PCLK_DDR_MON>; >> + clock-names = "pclk_ddr_mon"; >> + status = "disabled"; >> + }; >> + > > Remove the blank line. > > Thanks, > Chanwoo Choi Thanks, Chanwoo Choi