From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Alexandre TORGUE <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
u.kleine-koenig@pengutronix.de,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: V7M: Add dsb before jumping in handler mode
Date: Wed, 17 Aug 2016 16:28:39 +0100 [thread overview]
Message-ID: <57B482A7.1090104@arm.com> (raw)
In-Reply-To: <576175F3.5080306@arm.com>
On 15/06/16 16:36, Vladimir Murzin wrote:
> On 13/06/16 15:12, Alexandre TORGUE wrote:
>> According to ARM AN321 (section 4.12):
>>
>> "If the vector table is in writable memory such as SRAM, either relocated
>> by VTOR or a device dependent memory remapping mechanism, then
>> architecturally a memory barrier instruction is required after the vector
>> table entry is updated, and if the exception is to be activated
>> immediately"
>>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>
> Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
>
>> diff --git a/arch/arm/mm/proc-v7m.S b/arch/arm/mm/proc-v7m.S
>> index 7229d8d..2ddc435 100644
>> --- a/arch/arm/mm/proc-v7m.S
>> +++ b/arch/arm/mm/proc-v7m.S
>> @@ -104,6 +104,7 @@ __v7m_setup:
>> badr r1, 1f
>> ldr r5, [r12, #11 * 4] @ read the SVC vector entry
>> str r1, [r12, #11 * 4] @ write the temporary SVC vector entry
>> + dsb
>> mov r6, lr @ save LR
>> ldr sp, =init_thread_union + THREAD_START_SP
>> cpsie i
>>
>
Alex, xan you drop it into RMK's Patch system [1] please?
[1] http://www.armlinux.org.uk/developer/patches/
Thanks
Vladimir
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
prev parent reply other threads:[~2016-08-17 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:12 [PATCH] ARM: V7M: Add dsb before jumping in handler mode Alexandre TORGUE
2016-06-15 15:36 ` Vladimir Murzin
2016-08-17 15:28 ` Vladimir Murzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B482A7.1090104@arm.com \
--to=vladimir.murzin@arm.com \
--cc=alexandre.torgue@st.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox