From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753628AbcHRAsn convert rfc822-to-8bit (ORCPT ); Wed, 17 Aug 2016 20:48:43 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54052 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbcHRAsm (ORCPT ); Wed, 17 Aug 2016 20:48:42 -0400 X-AuditID: cbfee68d-f79286d000007a9a-0a-57b50352583a MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <57B50352.7050800@samsung.com> Date: Thu, 18 Aug 2016 09:37:38 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Guenter Roeck Cc: Guenter Roeck , MyungJoo Ham , linux-kernel , Guenter Roeck , Chris Zhong , "cpgs (cpgs@samsung.com)" Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property References: <1471266935-25287-1-git-send-email-linux@roeck-us.net> <57B2647B.4010203@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsWyRsSkUDeIeWu4waGdehYvD2lanHq1jNmi d9ESFovLu+awWTxZeIbJ4nbjCjaL+Q92MDuwe8xuuMjisWBTqcffWftZPHZ+b2D36NuyitHj 8ya5ALYoLpuU1JzMstQifbsErow5Dx4wFjQIVCx6vJa1gfE6TxcjJ4eEgInEqt8P2CBsMYkL 99aD2UICKxglpm2t7mLkAKu5P8Gsi5ELKLyUUeLI13usIDW8AoISPybfYwGpYRZQl5gyJRck zCwgItHQPp0VwtaWWLbwNTNE7wNGieOrJ7JB9GpJ3PyznQnEZhFQlejr6WIHsdmA4vtf3ACr 4RdQlLj64zEjyHxRgQiJ7hOVIGERoPJTT4+zgcxkFvjJKLFp2mSwXmEBL4nXx9+yQSxrYJK4 evM1WIJTIFii/fkyVpCEhMAjdol/W5vZIDYLSHybfIgF4ktZiU0HmCEBISlxcMUNlgmMErOQ /DkL4c9ZSP6cheTPBYwsqxhFUwuSC4qT0osM9YoTc4tL89L1kvNzNzECI/j0v2e9OxhvH7A+ xCjAwajEw9vBuDVciDWxrLgy9xCjKdBBE5mlRJPzgWkiryTe0NjMyMLUxNTYyNzSTEmcV1Hq Z7CQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxo38D/eW3wm7HhH1+7SlYotkeZaWQ0jE6idX MzdyhihaP/DNe7Vxz8J79hOceeU+GAT/DqhdI8u12yHM0OjI375IjZkTll4O9tbYPVf9+jJm dsXsPZXBfopT4vc9/KgTrv2hOFhNQekP8yb+8oLvKUsldmy6FrXbOM/9v5O8b8DD2YckK39O UmIpzkg01GIuKk4EAEzGKU/bAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsVy+t9jAd0g5q3hBnO2ali8PKRpcerVMmaL 3kVLWCwu75rDZvFk4Rkmi9uNK9gs5j/YwezA7jG74SKLx4JNpR5/Z+1n8dj5vYHdo2/LKkaP z5vkAtiiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4BOUVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmXNp3hKngFn/FpJWb GRsYN/J0MXJwSAiYSNyfYNbFyAlkiklcuLeerYuRi0NIYCmjxJGv91hBErwCghI/Jt9jAaln FpCXOHIpG8JUl5gyJRei/AGjxPHVE9kgyrUkbv7ZzgRiswioSvT1dLGD2GxA8f0vboDV8Aso Slz98ZgRZI6oQIRE94lKkLAIUPmpp8fBTmAW+MkosWnaZLBeYQEvidfH30Ld1sAkcfXma7AE p0CwRPvzZawTGAVnITl1FsKpsxBOXcDIvIpRIrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMj OOafSe9gPLzL/RCjAAejEg/vhptbwoVYE8uKK3MPMUpwMCuJ8H78BxTiTUmsrEotyo8vKs1J LT7EaAr060RmKdHkfGA6yiuJNzQ2MTOyNDI3tDAyNlcS5338f12YkEB6YklqdmpqQWoRTB8T B6dUA6Nw8VfOU4bbdpxwL3z86S33DZ022cunctN65AJ1Ku4FCs4w+v1Zvnb/NY6ARwbaV662 bZfYwyR1zDJmX4NVk9nxkpDrbjd+l82xTL/yumNTx4Ov9+6kSnedkPB8nFhstWZ1p+TesBk7 vxc8yU3mnCNVs91c4l7pAvtLtzu5gqdu+KPF1d22/pESS3FGoqEWc1FxIgBQqDrZDwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, How about changing the property name for SuperSpeed as following? It is more simple and reduce the length of property name. - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS Regards, Chanwoo Choi On 2016년 08월 16일 10:41, Guenter Roeck wrote: > On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi wrote: >> Hi Guenter, >> >> Looks good to me. >> I'll add the reference[1] information on patch description and applied it. >> [1] https://en.wikipedia.org/wiki/USB#Overview >> > > Thanks! > > Guenter > >> Thanks, >> Chanwoo Choi >> >> On 2016년 08월 15일 22:15, Guenter Roeck wrote: >>> From: Guenter Roeck >>> >>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >>> and USB3 connections on USB Type-C cables. >>> >>> Cc: Chris Zhong >>> Signed-off-by: Guenter Roeck >>> --- >>> Applies on top of extcon-next. >>> >>> include/linux/extcon.h | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>> index ad7a1606a7f3..38d2c0dec2c1 100644 >>> --- a/include/linux/extcon.h >>> +++ b/include/linux/extcon.h >>> @@ -107,12 +107,18 @@ >>> * @type: integer (intval) >>> * @value: 0 (normal) or 1 (flip) >>> * @default: 0 (normal) >>> + * - EXTCON_PROP_USB_SUPERSPEED >>> + * @type: integer (intval) >>> + * @value: 0 (USB/USB2) or 1 (USB3) >>> + * @default: 0 (USB/USB2) >>> + * >>> */ >>> #define EXTCON_PROP_USB_VBUS 0 >>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >>> +#define EXTCON_PROP_USB_SUPERSPEED 2 >>> >>> #define EXTCON_PROP_USB_MIN 0 >>> -#define EXTCON_PROP_USB_MAX 1 >>> +#define EXTCON_PROP_USB_MAX 2 >>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >>> >>> /* Properties of EXTCON_TYPE_CHG. */ >>> >> > > >