* [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property @ 2016-08-15 13:15 ` Guenter Roeck 2016-08-16 0:55 ` Chanwoo Choi 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2016-08-15 13:15 UTC (permalink / raw) To: Chanwoo Choi; +Cc: MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong From: Guenter Roeck <groeck@chromium.org> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 and USB3 connections on USB Type-C cables. Cc: Chris Zhong <zyw@rock-chips.com> Signed-off-by: Guenter Roeck <groeck@chromium.org> --- Applies on top of extcon-next. include/linux/extcon.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/extcon.h b/include/linux/extcon.h index ad7a1606a7f3..38d2c0dec2c1 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -107,12 +107,18 @@ * @type: integer (intval) * @value: 0 (normal) or 1 (flip) * @default: 0 (normal) + * - EXTCON_PROP_USB_SUPERSPEED + * @type: integer (intval) + * @value: 0 (USB/USB2) or 1 (USB3) + * @default: 0 (USB/USB2) + * */ #define EXTCON_PROP_USB_VBUS 0 #define EXTCON_PROP_USB_TYPEC_POLARITY 1 +#define EXTCON_PROP_USB_SUPERSPEED 2 #define EXTCON_PROP_USB_MIN 0 -#define EXTCON_PROP_USB_MAX 1 +#define EXTCON_PROP_USB_MAX 2 #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) /* Properties of EXTCON_TYPE_CHG. */ -- 2.5.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property 2016-08-15 13:15 ` [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck @ 2016-08-16 0:55 ` Chanwoo Choi 2016-08-16 1:41 ` Guenter Roeck 0 siblings, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2016-08-16 0:55 UTC (permalink / raw) To: Guenter Roeck; +Cc: MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong Hi Guenter, Looks good to me. I'll add the reference[1] information on patch description and applied it. [1] https://en.wikipedia.org/wiki/USB#Overview Thanks, Chanwoo Choi On 2016년 08월 15일 22:15, Guenter Roeck wrote: > From: Guenter Roeck <groeck@chromium.org> > > EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 > and USB3 connections on USB Type-C cables. > > Cc: Chris Zhong <zyw@rock-chips.com> > Signed-off-by: Guenter Roeck <groeck@chromium.org> > --- > Applies on top of extcon-next. > > include/linux/extcon.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index ad7a1606a7f3..38d2c0dec2c1 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -107,12 +107,18 @@ > * @type: integer (intval) > * @value: 0 (normal) or 1 (flip) > * @default: 0 (normal) > + * - EXTCON_PROP_USB_SUPERSPEED > + * @type: integer (intval) > + * @value: 0 (USB/USB2) or 1 (USB3) > + * @default: 0 (USB/USB2) > + * > */ > #define EXTCON_PROP_USB_VBUS 0 > #define EXTCON_PROP_USB_TYPEC_POLARITY 1 > +#define EXTCON_PROP_USB_SUPERSPEED 2 > > #define EXTCON_PROP_USB_MIN 0 > -#define EXTCON_PROP_USB_MAX 1 > +#define EXTCON_PROP_USB_MAX 2 > #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) > > /* Properties of EXTCON_TYPE_CHG. */ > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property 2016-08-16 0:55 ` Chanwoo Choi @ 2016-08-16 1:41 ` Guenter Roeck 2016-08-18 0:37 ` Chanwoo Choi 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2016-08-16 1:41 UTC (permalink / raw) To: Chanwoo Choi Cc: Guenter Roeck, MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Guenter, > > Looks good to me. > I'll add the reference[1] information on patch description and applied it. > [1] https://en.wikipedia.org/wiki/USB#Overview > Thanks! Guenter > Thanks, > Chanwoo Choi > > On 2016년 08월 15일 22:15, Guenter Roeck wrote: >> From: Guenter Roeck <groeck@chromium.org> >> >> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >> and USB3 connections on USB Type-C cables. >> >> Cc: Chris Zhong <zyw@rock-chips.com> >> Signed-off-by: Guenter Roeck <groeck@chromium.org> >> --- >> Applies on top of extcon-next. >> >> include/linux/extcon.h | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index ad7a1606a7f3..38d2c0dec2c1 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -107,12 +107,18 @@ >> * @type: integer (intval) >> * @value: 0 (normal) or 1 (flip) >> * @default: 0 (normal) >> + * - EXTCON_PROP_USB_SUPERSPEED >> + * @type: integer (intval) >> + * @value: 0 (USB/USB2) or 1 (USB3) >> + * @default: 0 (USB/USB2) >> + * >> */ >> #define EXTCON_PROP_USB_VBUS 0 >> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >> +#define EXTCON_PROP_USB_SUPERSPEED 2 >> >> #define EXTCON_PROP_USB_MIN 0 >> -#define EXTCON_PROP_USB_MAX 1 >> +#define EXTCON_PROP_USB_MAX 2 >> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >> >> /* Properties of EXTCON_TYPE_CHG. */ >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property 2016-08-16 1:41 ` Guenter Roeck @ 2016-08-18 0:37 ` Chanwoo Choi 2016-08-18 0:41 ` Guenter Roeck 0 siblings, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2016-08-18 0:37 UTC (permalink / raw) To: Guenter Roeck Cc: Guenter Roeck, MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong, cpgs (cpgs@samsung.com) Hi Guenter, How about changing the property name for SuperSpeed as following? It is more simple and reduce the length of property name. - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS Regards, Chanwoo Choi On 2016년 08월 16일 10:41, Guenter Roeck wrote: > On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi Guenter, >> >> Looks good to me. >> I'll add the reference[1] information on patch description and applied it. >> [1] https://en.wikipedia.org/wiki/USB#Overview >> > > Thanks! > > Guenter > >> Thanks, >> Chanwoo Choi >> >> On 2016년 08월 15일 22:15, Guenter Roeck wrote: >>> From: Guenter Roeck <groeck@chromium.org> >>> >>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >>> and USB3 connections on USB Type-C cables. >>> >>> Cc: Chris Zhong <zyw@rock-chips.com> >>> Signed-off-by: Guenter Roeck <groeck@chromium.org> >>> --- >>> Applies on top of extcon-next. >>> >>> include/linux/extcon.h | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>> index ad7a1606a7f3..38d2c0dec2c1 100644 >>> --- a/include/linux/extcon.h >>> +++ b/include/linux/extcon.h >>> @@ -107,12 +107,18 @@ >>> * @type: integer (intval) >>> * @value: 0 (normal) or 1 (flip) >>> * @default: 0 (normal) >>> + * - EXTCON_PROP_USB_SUPERSPEED >>> + * @type: integer (intval) >>> + * @value: 0 (USB/USB2) or 1 (USB3) >>> + * @default: 0 (USB/USB2) >>> + * >>> */ >>> #define EXTCON_PROP_USB_VBUS 0 >>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >>> +#define EXTCON_PROP_USB_SUPERSPEED 2 >>> >>> #define EXTCON_PROP_USB_MIN 0 >>> -#define EXTCON_PROP_USB_MAX 1 >>> +#define EXTCON_PROP_USB_MAX 2 >>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >>> >>> /* Properties of EXTCON_TYPE_CHG. */ >>> >> > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property 2016-08-18 0:37 ` Chanwoo Choi @ 2016-08-18 0:41 ` Guenter Roeck 2016-08-18 1:25 ` Chanwoo Choi 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2016-08-18 0:41 UTC (permalink / raw) To: Chanwoo Choi Cc: Guenter Roeck, MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong, cpgs (cpgs@samsung.com) On Wed, Aug 17, 2016 at 5:37 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Guenter, > > How about changing the property name for SuperSpeed as following? > It is more simple and reduce the length of property name. > - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS > Whatever you prefer is fine. Thanks, Guenter > Regards, > Chanwoo Choi > > On 2016년 08월 16일 10:41, Guenter Roeck wrote: >> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>> Hi Guenter, >>> >>> Looks good to me. >>> I'll add the reference[1] information on patch description and applied it. >>> [1] https://en.wikipedia.org/wiki/USB#Overview >>> >> >> Thanks! >> >> Guenter >> >>> Thanks, >>> Chanwoo Choi >>> >>> On 2016년 08월 15일 22:15, Guenter Roeck wrote: >>>> From: Guenter Roeck <groeck@chromium.org> >>>> >>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >>>> and USB3 connections on USB Type-C cables. >>>> >>>> Cc: Chris Zhong <zyw@rock-chips.com> >>>> Signed-off-by: Guenter Roeck <groeck@chromium.org> >>>> --- >>>> Applies on top of extcon-next. >>>> >>>> include/linux/extcon.h | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>>> index ad7a1606a7f3..38d2c0dec2c1 100644 >>>> --- a/include/linux/extcon.h >>>> +++ b/include/linux/extcon.h >>>> @@ -107,12 +107,18 @@ >>>> * @type: integer (intval) >>>> * @value: 0 (normal) or 1 (flip) >>>> * @default: 0 (normal) >>>> + * - EXTCON_PROP_USB_SUPERSPEED >>>> + * @type: integer (intval) >>>> + * @value: 0 (USB/USB2) or 1 (USB3) >>>> + * @default: 0 (USB/USB2) >>>> + * >>>> */ >>>> #define EXTCON_PROP_USB_VBUS 0 >>>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >>>> +#define EXTCON_PROP_USB_SUPERSPEED 2 >>>> >>>> #define EXTCON_PROP_USB_MIN 0 >>>> -#define EXTCON_PROP_USB_MAX 1 >>>> +#define EXTCON_PROP_USB_MAX 2 >>>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >>>> >>>> /* Properties of EXTCON_TYPE_CHG. */ >>>> >>> >> >> >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property 2016-08-18 0:41 ` Guenter Roeck @ 2016-08-18 1:25 ` Chanwoo Choi 0 siblings, 0 replies; 6+ messages in thread From: Chanwoo Choi @ 2016-08-18 1:25 UTC (permalink / raw) To: Guenter Roeck Cc: Guenter Roeck, MyungJoo Ham, linux-kernel, Guenter Roeck, Chris Zhong, cpgs (cpgs@samsung.com) On 2016년 08월 18일 09:41, Guenter Roeck wrote: > On Wed, Aug 17, 2016 at 5:37 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi Guenter, >> >> How about changing the property name for SuperSpeed as following? >> It is more simple and reduce the length of property name. >> - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS >> > Whatever you prefer is fine. OK. Thanks. I'll change the property name. Regards, Chanwoo Choi > > Thanks, > Guenter > >> Regards, >> Chanwoo Choi >> >> On 2016년 08월 16일 10:41, Guenter Roeck wrote: >>> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>>> Hi Guenter, >>>> >>>> Looks good to me. >>>> I'll add the reference[1] information on patch description and applied it. >>>> [1] https://en.wikipedia.org/wiki/USB#Overview >>>> >>> >>> Thanks! >>> >>> Guenter >>> >>>> Thanks, >>>> Chanwoo Choi >>>> >>>> On 2016년 08월 15일 22:15, Guenter Roeck wrote: >>>>> From: Guenter Roeck <groeck@chromium.org> >>>>> >>>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >>>>> and USB3 connections on USB Type-C cables. >>>>> >>>>> Cc: Chris Zhong <zyw@rock-chips.com> >>>>> Signed-off-by: Guenter Roeck <groeck@chromium.org> >>>>> --- >>>>> Applies on top of extcon-next. >>>>> >>>>> include/linux/extcon.h | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>>>> index ad7a1606a7f3..38d2c0dec2c1 100644 >>>>> --- a/include/linux/extcon.h >>>>> +++ b/include/linux/extcon.h >>>>> @@ -107,12 +107,18 @@ >>>>> * @type: integer (intval) >>>>> * @value: 0 (normal) or 1 (flip) >>>>> * @default: 0 (normal) >>>>> + * - EXTCON_PROP_USB_SUPERSPEED >>>>> + * @type: integer (intval) >>>>> + * @value: 0 (USB/USB2) or 1 (USB3) >>>>> + * @default: 0 (USB/USB2) >>>>> + * >>>>> */ >>>>> #define EXTCON_PROP_USB_VBUS 0 >>>>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >>>>> +#define EXTCON_PROP_USB_SUPERSPEED 2 >>>>> >>>>> #define EXTCON_PROP_USB_MIN 0 >>>>> -#define EXTCON_PROP_USB_MAX 1 >>>>> +#define EXTCON_PROP_USB_MAX 2 >>>>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >>>>> >>>>> /* Properties of EXTCON_TYPE_CHG. */ >>>>> >>>> >>> >>> >>> >> > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-18 1:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160815131555epcas1p2866c4a7f64e521c7b7aea2b7a8acc0e4@epcas1p2.samsung.com>
2016-08-15 13:15 ` [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck
2016-08-16 0:55 ` Chanwoo Choi
2016-08-16 1:41 ` Guenter Roeck
2016-08-18 0:37 ` Chanwoo Choi
2016-08-18 0:41 ` Guenter Roeck
2016-08-18 1:25 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox