From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbcHRBg3 (ORCPT ); Wed, 17 Aug 2016 21:36:29 -0400 Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:45758 "HELO gproxy6-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752936AbcHRBg2 (ORCPT ); Wed, 17 Aug 2016 21:36:28 -0400 X-Greylist: delayed 1598 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 Aug 2016 21:36:27 EDT X-Authority-Analysis: v=2.1 cv=AL9Ak13q c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=N659UExz7-8A:10 a=05RPwmwRPNYA:10 a=I4ko-sDDNxYA:10 a=7z1cN_iqozsA:10 a=LCBk-01sbgFbAKIO_mAA:9 a=pILNOxqGKmIA:10 a=UccDexJt0acA:10 Subject: Re: [PATCH 06/15] genhd: Add return code to device_add_disk To: Fam Zheng , Cornelia Huck References: <1471418115-3654-1-git-send-email-famz@redhat.com> <1471418115-3654-7-git-send-email-famz@redhat.com> <20160817104914.37087cb3.cornelia.huck@de.ibm.com> <20160817084823.GB19326@al.usersys.redhat.com> <20160817110645.45370f57.cornelia.huck@de.ibm.com> <20160817091422.GE19326@al.usersys.redhat.com> Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, Sergey Senozhatsky , "Michael S. Tsirkin" , Michael Ellerman , virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, Keith Busch , Minchan Kim , Paul Mackerras , Benjamin Herrenschmidt , linux-mtd@lists.infradead.org, Brian Norris , linuxppc-dev@lists.ozlabs.org, David Woodhouse , Nitin Gupta From: Ed Cashin Message-ID: <57B50AD1.6010403@acm.org> Date: Wed, 17 Aug 2016 21:09:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160817091422.GE19326@al.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {2969:box320.bluehost.com:cashinwo:cashinworks.com} {sentby:smtp auth 98.192.52.118 authed with ed@cashinworks.com} X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box320.bluehost.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - acm.org X-Source-IP: 98.192.52.118 X-Exim-ID: 1baBq1-0000cr-3r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([10.0.1.46]) [98.192.52.118]:49147 X-Source-Auth: ed@cashinworks.com X-Email-Count: 0 X-Source-Cap: Y2FzaGlud287Y2FzaGlud287Ym94MzIwLmJsdWVob3N0LmNvbQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 05:14 AM, Fam Zheng wrote: ... > Of course, the plan is to write patches on top. I'm not cleaning up anything > here because I'm concerned callers may double free (and I didn't look hard into > that). Aside from Huck's concerns, the changes looked OK from aoe's perspective. -- Ed