From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbcHRB0A convert rfc822-to-8bit (ORCPT ); Wed, 17 Aug 2016 21:26:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:43717 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915AbcHRBZ6 (ORCPT ); Wed, 17 Aug 2016 21:25:58 -0400 X-AuditID: cbfee68d-f79286d000007a9a-53-57b50ea46674 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <57B50EA3.4090609@samsung.com> Date: Thu, 18 Aug 2016 10:25:55 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Guenter Roeck Cc: Guenter Roeck , MyungJoo Ham , linux-kernel , Guenter Roeck , Chris Zhong , "cpgs (cpgs@samsung.com)" Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property References: <1471266935-25287-1-git-send-email-linux@roeck-us.net> <57B2647B.4010203@samsung.com> <57B50352.7050800@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWyRsSkUHcJ39ZwgwPLxS1eHtK0OPVqGbNF 76IlLBaXd81hs3iy8AyTxe3GFWwW8x/sYHZg95jdcJHFY8GmUo+/s/azeOz83sDu0bdlFaPH 501yAWxRXDYpqTmZZalF+nYJXBlHmm8xF2wXrrhy+QxjA+NR/i5GTg4JAROJKY1rmCBsMYkL 99azdTFycQgJrGCUmHb2PCNMUeO6DmYQW0hgKaPE6x9yIDavgKDEj8n3WLoYOTiYBdQlpkzJ BQkzC4hI3Dj7hhXC1pZYtvA1M8TMB4wSR6ZfZofo1ZJ4cuU9WBGLgKrEohMvwI5gA4rvf3GD DcTmF1CUuPrjMSPIfFGBCInuE5UgYRGg8lNPj4PdySzwk1Fi07TJYDOFBbwkXh9/C/XACyaJ C9NbwBKcAsESs/ccAUtICDxil2jpO8YCsVlA4tvkQ2AfSAjISmw6wAzxsKTEwRU3WCYwSsxC 8ucshD9nIflzFpI/FzCyrGIUTS1ILihOSi8y1CtOzC0uzUvXS87P3cQIjOHT/5717mC8fcD6 EKMAB6MSD+8Ejq3hQqyJZcWVuYcYTYEOmsgsJZqcD0wUeSXxhsZmRhamJqbGRuaWZkrivIpS P4OFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MMa4hZ1RSmZu2Bmw+82UK7b+5U/PJEWumXNg gfei6Lulb/ovGni+/BJ1xFZ8meeWbq2D984c+/j16vPu0qYZBZ42Pj3+1+91dqixfgq6yrZL 7Uz+grtCm6tPrgvsevc1ble/++S/G9cfv+Kz7rTJNul7JyrUjtan/7z4IqB/euC9VNlV1pqF j9YosRRnJBpqMRcVJwIAq25HwdwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsVy+t9jAd0lfFvDDRoPCFq8PKRpcerVMmaL 3kVLWCwu75rDZvFk4Rkmi9uNK9gs5j/YwezA7jG74SKLx4JNpR5/Z+1n8dj5vYHdo2/LKkaP z5vkAtiiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4BOUVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmfF30kbXgv1DFnIvN LA2MvfxdjJwcEgImEo3rOpghbDGJC/fWs4HYQgJLGSVe/5ADsXkFBCV+TL7H0sXIwcEsIC9x 5FI2hKkuMWVKbhcjF1D1A0aJI9Mvs0OUa0k8ufKeFcRmEVCVWHTiBROIzQYU3//iBth4fgFF ias/HjOCzBEViJDoPlEJEhYBKj/19DgbyExmgZ+MEpumTQabKSzgJfH6+Fs2iGUvmCQuTG8B S3AKBEvM3nOEbQKj4Cwkp85COHUWwqkLGJlXMUqkFiQXFCel5xrmpZbrFSfmFpfmpesl5+du YgTH/DOpHYwHd7kfYhTgYFTi4d0xdUu4EGtiWXFl7iFGCQ5mJRFeUd6t4UK8KYmVValF+fFF pTmpxYcYTYF+ncgsJZqcD0xHeSXxhsYmZkaWRuaGFkbG5krivI//rwsTEkhPLEnNTk0tSC2C 6WPi4JRqYDw59ZrgR0czo1ONNn/KNC9qRzCv/TthhuUbFueDG/j4NkVPCJpXze8V1nXGLcxG xiSJ9fXqbZcVpPX/zFY05zx1J23KorsZn5eUm5qyqu4/V6vAfzbsDP++3a92bFK6yWRcYhvz 39dz2ZEdJiyFjEZGS7oPt9jyuTSen6H1x215mUuvsd7vVCWW4oxEQy3mouJEAJ5kHmIPAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 08월 18일 09:41, Guenter Roeck wrote: > On Wed, Aug 17, 2016 at 5:37 PM, Chanwoo Choi wrote: >> Hi Guenter, >> >> How about changing the property name for SuperSpeed as following? >> It is more simple and reduce the length of property name. >> - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS >> > Whatever you prefer is fine. OK. Thanks. I'll change the property name. Regards, Chanwoo Choi > > Thanks, > Guenter > >> Regards, >> Chanwoo Choi >> >> On 2016년 08월 16일 10:41, Guenter Roeck wrote: >>> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi wrote: >>>> Hi Guenter, >>>> >>>> Looks good to me. >>>> I'll add the reference[1] information on patch description and applied it. >>>> [1] https://en.wikipedia.org/wiki/USB#Overview >>>> >>> >>> Thanks! >>> >>> Guenter >>> >>>> Thanks, >>>> Chanwoo Choi >>>> >>>> On 2016년 08월 15일 22:15, Guenter Roeck wrote: >>>>> From: Guenter Roeck >>>>> >>>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2 >>>>> and USB3 connections on USB Type-C cables. >>>>> >>>>> Cc: Chris Zhong >>>>> Signed-off-by: Guenter Roeck >>>>> --- >>>>> Applies on top of extcon-next. >>>>> >>>>> include/linux/extcon.h | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>>>> index ad7a1606a7f3..38d2c0dec2c1 100644 >>>>> --- a/include/linux/extcon.h >>>>> +++ b/include/linux/extcon.h >>>>> @@ -107,12 +107,18 @@ >>>>> * @type: integer (intval) >>>>> * @value: 0 (normal) or 1 (flip) >>>>> * @default: 0 (normal) >>>>> + * - EXTCON_PROP_USB_SUPERSPEED >>>>> + * @type: integer (intval) >>>>> + * @value: 0 (USB/USB2) or 1 (USB3) >>>>> + * @default: 0 (USB/USB2) >>>>> + * >>>>> */ >>>>> #define EXTCON_PROP_USB_VBUS 0 >>>>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1 >>>>> +#define EXTCON_PROP_USB_SUPERSPEED 2 >>>>> >>>>> #define EXTCON_PROP_USB_MIN 0 >>>>> -#define EXTCON_PROP_USB_MAX 1 >>>>> +#define EXTCON_PROP_USB_MAX 2 >>>>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1) >>>>> >>>>> /* Properties of EXTCON_TYPE_CHG. */ >>>>> >>>> >>> >>> >>> >> > > >