From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbcHRHOS (ORCPT ); Thu, 18 Aug 2016 03:14:18 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:50011 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752435AbcHRHOQ (ORCPT ); Thu, 18 Aug 2016 03:14:16 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="10035388" Message-ID: <57B55FC3.8050302@cn.fujitsu.com> Date: Thu, 18 Aug 2016 15:12:03 +0800 From: =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dave Young , Joe Perches CC: , , , , , , , Subject: Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus References: <1471487495-22787-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <1471487495-22787-2-git-send-email-zhouwj-fnst@cn.fujitsu.com> <1471487809.4319.15.camel@perches.com> <20160818064715.GC26001@dhcp-128-65.nay.redhat.com> In-Reply-To: <20160818064715.GC26001@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-yoursite-MailScanner-ID: A03A942BC504.AA5A8 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: zhouwj-fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2016 02:47 PM, Dave Young wrote: > On 08/17/16 at 07:36pm, Joe Perches wrote: >> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote: >>> nr_cpus can help to save memory. So we should remind user of it. >> >> trivia: >>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt >> [] >>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel: >>> * Boot parameter "1" boots the dump-capture kernel into single-user >>> mode without networking. If you want networking, use "3". >>> >>> -* We generally don' have to bring up a SMP kernel just to capture the >>> +* We generally don' have to bring up an SMP kernel just to capture the >> >> don't or do not >> > > Use do not is better, also need replace 'We' with 'You' to be > consistent with other part. > > I think it's better to fix it in another patch, for it doesn't have much relevance to the patch set. I'll post it alone later. -- Thanks Zhou