From: zijun_hu <zijun_hu@zoho.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dhowells@redhat.com, linux-kernel@vger.kernel.org,
zijun_hu@htc.com
Subject: Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent
Date: Thu, 18 Aug 2016 20:11:20 +0800 [thread overview]
Message-ID: <57B5A5E8.3040606@zoho.com> (raw)
In-Reply-To: <20160818090116.GA25687@twins.programming.kicks-ass.net>
On 08/18/2016 05:01 PM, Peter Zijlstra wrote:
> On Thu, Aug 18, 2016 at 04:19:10PM +0800, zijun_hu wrote:
>> From: zijun_hu <zijun_hu@htc.com>
>>
>> for LP64 ABI, struct rb_node aligns at 8 bytes boundary due to
>> sizeof(long) == 8 normally, so 0x07 should be used to extract
>> node's parent rather than 0x03
>
> Doesn't matter though, in practise. The remaining bits are always 0.
>
okay, understand
it maybe more readable to replace hard coding numbers by macros
prev parent reply other threads:[~2016-08-18 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 8:19 [PATCH 1/1] rbtree: correct mask for extracting node's parent zijun_hu
2016-08-18 9:01 ` Peter Zijlstra
2016-08-18 12:11 ` zijun_hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B5A5E8.3040606@zoho.com \
--to=zijun_hu@zoho.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=zijun_hu@htc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox