From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754552AbcHSFl6 (ORCPT ); Fri, 19 Aug 2016 01:41:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:29295 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753910AbcHSFln (ORCPT ); Fri, 19 Aug 2016 01:41:43 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com Subject: Re: [PATCH v4 0/3] perf annotate: Enable cross arch annotate To: acme@kernel.org References: <1467952813-5797-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <57860D9E.7000906@linux.vnet.ibm.com> Cc: mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, anton@ozlabs.org, ananth@in.ibm.com, dja@axtens.net, naveen.n.rao@linux.vnet.ibm.com, David.Laight@ACULAB.COM, rmk+kernel@arm.linux.org.uk From: Ravi Bangoria Date: Fri, 19 Aug 2016 11:11:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <57860D9E.7000906@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081905-0004-0000-0000-0000102CA746 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005614; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00746725; UDB=6.00352092; IPR=6.00519247; BA=6.00004668; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012384; XFM=3.00000011; UTC=2016-08-19 05:41:40 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081905-0005-0000-0000-0000781C678F Message-Id: <57B69C0B.6030703@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-19_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608190064 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've sent v5 series for this. Please review it. Thanks, Ravi On Wednesday 13 July 2016 03:15 PM, Ravi Bangoria wrote: > Arnaldo, Michael, > > I've tested this patchset on ppc64 BE and LE both. Please review this. > > -Ravi > > On Friday 08 July 2016 10:10 AM, Ravi Bangoria wrote: >> Perf can currently only support code navigation (branches and calls) in >> annotate when run on the same architecture where perf.data was recorded. >> But cross arch annotate is not supported. >> >> This patchset enables cross arch annotate. Currently I've used x86 >> and arm instructions which are already available and adding support >> for powerpc as well. Adding support for other arch will be easy. >> >> I've created this patch on top of acme/perf/core. And tested it with >> x86 and powerpc only. >> >> Note for arm: >> Few instructions were defined under #if __arm__ which I've used as a >> table for arm. But I'm not sure whether instruction defined outside of >> that also contains arm instructions. Apart from that, 'call__parse()' >> and 'move__parse()' contains #ifdef __arm__ directive. I've changed it >> to if (!strcmp(norm_arch, arm)). I don't have a arm machine to test >> these changes. >> >> Example: >> >> Record on powerpc: >> $ ./perf record -a >> >> Report -> Annotate on x86: >> $ ./perf report -i perf.data.powerpc --vmlinux vmlinux.powerpc >> >> Changes in v4: >> - powerpc: Added support for branch instructions that includes 'ctr' >> - __maybe_unused was misplaced at few location. Corrected it. >> - Moved position of v3 last patch that define macro for each arch name >> >> v3 link: https://lkml.org/lkml/2016/6/30/99 >> >> Naveen N. Rao (1): >> perf annotate: add powerpc support >> >> Ravi Bangoria (2): >> perf: Define macro for normalized arch names >> perf annotate: Enable cross arch annotate >> >> tools/perf/arch/common.c | 36 ++--- >> tools/perf/arch/common.h | 11 ++ >> tools/perf/builtin-top.c | 2 +- >> tools/perf/ui/browsers/annotate.c | 3 +- >> tools/perf/ui/gtk/annotate.c | 2 +- >> tools/perf/util/annotate.c | 273 ++++++++++++++++++++++++++++++------- >> tools/perf/util/annotate.h | 6 +- >> tools/perf/util/unwind-libunwind.c | 4 +- >> 8 files changed, 265 insertions(+), 72 deletions(-) >> >> -- >> 2.5.5 >> >