From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756623AbcHWCfc convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2016 22:35:32 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36194 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753407AbcHWCfa (ORCPT ); Mon, 22 Aug 2016 22:35:30 -0400 X-AuditID: cbfee68e-f79cb6d000006cfe-b0-57bbb66ea500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <57BBB66E.2060807@samsung.com> Date: Tue, 23 Aug 2016 11:35:26 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Stephen Boyd Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> In-reply-to: <20160823005512.GP6502@codeaurora.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkUDdv2+5wg19TNS0m3rjCYvH6haFF /+PXzBabHl9jtfjYc4/V4vKuOWwWM87vY7K4eMrV4vCbdlaLH2e6WSxW7frD6MDt8f5GK7vH 5b5eJo+ds+6ye2xa1cnmsXlJvUffllWMHp83yQWwR3HZpKTmZJalFunbJXBlrPnTyFrQK1hx 7fwWlgbGSXxdjJwcEgImEje6TzJD2GISF+6tZ+ti5OIQEljBKHF84mUmmKLzizpZIRJLGSWu HtgC1sErICjxY/I9FhCbWUBdYtK8RcwQtojErmd32CFsbYllC1+DxYUEHjBK3Jwh18XIAdSr JXFoXy1ImEVAVeLpkm9g5WxA4f0vbrCB2PwCihJXfzxmBCkXFYiQ6D5RCRIWAdr0fcdJsDuZ BSYySSxfNQWsV1ggUeLRs4tMEHf+Y5Q4uKOBBaSZU8BY4tgTc5C4hEAvh8Te9rPMEIsFJL5N PgRWIyEgK7HpADQgJCUOrrjBMoFRYhaSL2ch+XIWki9nIflyASPLKkbR1ILkguKk9CIjveLE 3OLSvHS95PzcTYzAmD/971nfDsabB6wPMQpwMCrx8O5g3x0uxJpYVlyZe4jRFOiiicxSosn5 wMSSVxJvaGxmZGFqYmpsZG5ppiTOmyD1M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo/L7 z5eELKdnOGa+Ya1Qe/7trO3+7tXBv9f1BZQpJz5UqCgOvO5j+nbalE2eh0LFep/bnrC9Malu 5ponBbsYsyfUzWmetZD355pYlXP132JLTDhVv/juXHBGJUo6TsH8ZdiEowkVQbXmN51vGZdt FY84fvLD+8cLGyJ+K31zWGB4W9du59//UUosxRmJhlrMRcWJAMWqKYL0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jAd28bbvDDRpfKllMvHGFxeL1C0OL /sevmS02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxeE37awWP850s1is2vWH0YHb4/2NVnaP y329TB47Z91l99i0qpPNY/OSeo++LasYPT5vkgtgj2pgtMlITUxJLVJIzUvOT8nMS7dV8g6O d443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBOlFJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOE rm9IEFyPkQEaSFjDmPH8qkzBfYGKm++WsTUwPuHtYuTkkBAwkTi/qJMVwhaTuHBvPVsXIxeH kMBSRomrB7YwgyR4BQQlfky+x9LFyMHBLCAvceRSNkiYWUBdYtK8RWAlQgIPGCVuzpADKeEV 0JI4tK8WJMwioCrxdMk3dhCbDSi8/8UNNhCbX0BR4uqPx4wg5aICERLdJypBwiJAE7/vOAl2 AbPARCaJ5aumgPUKCyRKPHp2kQnitH+MEgd3NICdwylgLHHsifkERsFZSA6dhXDoLCSHLmBk XsUokVqQXFCclJ5rmJdarlecmFtcmpeul5yfu4kRnCCeSe1gPLjL/RCjAAejEg/vDvbd4UKs iWXFlbmHGCU4mJVEeC23AIV4UxIrq1KL8uOLSnNSiw8xmgL9OpFZSjQ5H5i88kriDY1NzIws jcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwHhg6r0vPk+lrmdNLdvUuvgbV+qO qdt1TDk+379R2iSlKLD67jzVc6H1bkseyVvm+hyoZvRIs3i47qHK9q6lIo41fE9UZx/n22gi q59cllzhtFrM57zrlKWP9y47GS4dmHU2I8l7cdOn+2vW5OwKfX9gz0yHj8rFC15+vldWFPWk eoeAywMGzX4lluKMREMt5qLiRADKreoxJgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 2016년 08월 23일 09:55, Stephen Boyd wrote: > On 08/22, Chanwoo Choi wrote: >> This patch moves the all samsung_cmu_info struct to initconst section >> because they are used only in initconst section. >> >> Signed-off-by: Chanwoo Choi >> --- >> drivers/clk/samsung/clk-exynos5260.c | 350 +++++++++++++++++------------------ >> 1 file changed, 175 insertions(+), 175 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5260.c b/drivers/clk/samsung/clk-exynos5260.c >> index a43642c36039..fd1d9bfc151b 100644 >> --- a/drivers/clk/samsung/clk-exynos5260.c >> +++ b/drivers/clk/samsung/clk-exynos5260.c >> @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = { >> EN_IP_AUD, 4, 0, 0), >> }; >> >> +static const struct samsung_cmu_info aud_cmu __initconst = { >> + .mux_clks = aud_mux_clks, >> + .nr_mux_clks = ARRAY_SIZE(aud_mux_clks), >> + .div_clks = aud_div_clks, >> + .nr_div_clks = ARRAY_SIZE(aud_div_clks), >> + .gate_clks = aud_gate_clks, >> + .nr_gate_clks = ARRAY_SIZE(aud_gate_clks), >> + .nr_clk_ids = AUD_NR_CLK, >> + .clk_regs = aud_clk_regs, >> + .nr_clk_regs = ARRAY_SIZE(aud_clk_regs), >> +}; >> + >> static void __init exynos5260_clk_aud_init(struct device_node *np) >> { >> - struct samsung_cmu_info cmu = { NULL }; >> - > > I presume this was done this way to save some initdata space by > only allocating the array that's needed at runtime? I would > expect to see some more kernel image bloat from this change but > runtime memory usage would stay the same. Is there any real > benefit from this patch though? > After this patch, 'struct samsung_cmu_info' size should be added to kernel image and then the size of deleted code should be removed from kernel image. I think that it is not bloating. (struct samsung_cmu_info includes the pointer and integer value.) This patch make the code more simple and improve the readability. And, the samsung_cmu_register_on() requires the 'const' type argument for 'struct samsung_cmu_info'. Regards, Chanwoo Choi