From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbcHWPif (ORCPT ); Tue, 23 Aug 2016 11:38:35 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35423 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbcHWPiE (ORCPT ); Tue, 23 Aug 2016 11:38:04 -0400 Subject: Re: [PATCH 1/2] drivers/clocksource/pistachio: fix memory corruption in init To: Marcin Nowakowski , tglx@linutronix.de References: <1471429354-16045-1-git-send-email-marcin.nowakowski@imgtec.com> Cc: linux-kernel@vger.kernel.org From: Daniel Lezcano Message-ID: <57BC6C53.9090503@linaro.org> Date: Tue, 23 Aug 2016 17:31:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1471429354-16045-1-git-send-email-marcin.nowakowski@imgtec.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 12:22 PM, Marcin Nowakowski wrote: > Driver init code incorrectly uses the block base address and as a result > clears clocksource structure's fields instead of the hardware registers. > > Commit 09a998201649 ("timekeeping: Lift clocksource cacheline > restriction") has changed the offsets within pistachio_clocksource > structure and what has previously gone unnoticed now leads to a kernel > panic during boot. > > Signed-off-by: Marcin Nowakowski > --- Ok, I applied this patch as an urgent fix. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog