From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbcHWT5m (ORCPT ); Tue, 23 Aug 2016 15:57:42 -0400 Received: from mail-sn1nam02on0111.outbound.protection.outlook.com ([104.47.36.111]:18962 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753819AbcHWT5j (ORCPT ); Tue, 23 Aug 2016 15:57:39 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57BCAA48.6050202@hpe.com> Date: Tue, 23 Aug 2016 15:55:52 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Peter Zijlstra CC: Linus Torvalds , Jason Low , Ding Tianhong , Thomas Gleixner , Will Deacon , Ingo Molnar , Imre Deak , Linux Kernel Mailing List , Davidlohr Bueso , Tim Chen , Terry Rudd , "Paul E. McKenney" , Jason Low Subject: Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner References: <20160823124617.015645861@infradead.org> <20160823124856.763266868@infradead.org> In-Reply-To: <20160823124856.763266868@infradead.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.126] X-ClientProxiedBy: CY1PR14CA0010.namprd14.prod.outlook.com (10.163.13.148) To TU4PR84MB0320.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.30) X-MS-Office365-Filtering-Correlation-Id: 8a7e6b55-0312-45b5-6ac0-08d3cb8f807c X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0320;2:Wxo9WH9YEOvQ39c0nNozcOmoQ7xCGU5AfTID7uunEv8rgubB5FUD/dW6UVLIacMvHY6rIpQXOtSzwRCfMEIqJHSOQ6puy8xi9adtlUQegjQbywD7Mcxn6EmcY13uewQEhISnqYeKNQ6R/QPi4IsR8tnPqNjAROu2mfiTZcUsE9h9H76n9Jt0okg4kT8/cKpE;3:jCFeJ7YM+Y1I1IviOt7ck9fjy4/8JdSVg7CRrOU3jj8EaTDf1czckR87un7TrchjyRJDWYrCH0fVaiP1KUbpvXha+6h+5iYUiF9Jq4oQGl7qvi+E+UTYcznmFRt0oeES;25:nlN535Hm9Sx+pbRvu+UNmvzEyVYcrpZYHZZJ2OKDLWBY0qKTqsSRR+V7eN0mxSvsr3c/jlDrQUv+BAZvpkzJWu92gAIaZ4lDXPVMl3oqmLZaqt8JKQUi57K3IDelG6o+oB6F/5QD2b+ZnjhRETmDFYdydqcZR8eWqb27BeIuD6V6Ugo3C8i762nzHWwIWN8NsVomRCLcoLMQy1mN1u4U57E/nik5Z0yH/RuUSnlvFT6tmMjRe2CgDXSTZ56cIRpGRMsanrKsZOc8Zt2o+bXRyQ0TscI1SokX+8k5D3+H2VNlKcLbxalPTWuxGou10MY4islGmy8WOsj6K/GgzQi7Rv8wXdkSSeBytCrtr8VzCdkoHZ86HB9AtRbb+xAcV2Dbyssuwphm8vLnfTc4a6mrjtS+ybaLLzIz0sK0O14iXCs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0320; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0320;31:Jkd4JdbCbmkUdYKSnKmJojj6x+6Ne9Paj7a5OfcNDl7StnZtoJl5dHUaS67Bj5a9wyZ5fwLx+eA2rAXzxVELeiP7U5f1WugEZXUKjbYc1fuS1kqkVqvqx1MIFgL34bDQ2PVPi3PBldrCib99kPQU6gMOJm2q87+g/AQ1ExueQ2qf7qslfwDtFXUV5qJoCQPiuQ0dchn2YTIz1TWyFg/yd4XEboMRxT7B+x7B5APbMKA=;20:b2vRxYaZj1WEwgc4hNAH7BAKn0fu2BSaKG5aF8mnfEImvxBXVjF4cs8VrZnrE7IcSYXO5AyD4Rlulw/Hr6SGO0WrYl49shx9xgytBHTDMn3lIRFWf18GWWyQbL9OhSf0JCtBlOvXq42ap4OyvjSJ4gCB7FWO9pSh4jEhhczvEi1HmbjWmly7eGWjxByDpQTmJe8kaSFBsEY9LnsfW6dMigF2aY6uLmKZF5a7vRq0NcoqdmB8530FDizy4SoSgt0tJl2oOx0oCuON+6+j1AcCo5hENofZ5AXuCDQ8/CoDQnaydovnsLaW8j40bLwkDJvrRbPiimmIwjSX/RD7YM+FE+T2BvZIVeymqMt3lM/EfIaugAw7lwboZuGnLL4KkRa25LOH5f729WTwNWqA3fYJp5xJYcNHM3kVpfxBfjdfypP699dau9lNp7lElu1MBX6S3B56wDCkR+eAhgQJVzhyeyXPfG42DdjukK2Pk/cNXYHr3P3O90NXV16klDs5FuvA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:TU4PR84MB0320;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0320; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0320;4:kRKFi1JBI40c+iFBm41GF5GyRk3x9IX8WbP3Fg0QrTeJlrOrjphOlKB1THanNAsyT+gdMkyf2EmkZRBVU+bjk4rQmZHbCgIT/L4nRnuUdZrsH8g+NfwU3FkpXhLtF99JCcTIuj1Ocfq0liLBuuMtkRTZt+Tq8VtCjiaxLAWLyjfqYFiLTh9EY9IAZldWVZTfnITtIV2x1D5TzzQNO8y+OpinrTGo1RZMpu8yL4dFKiGLQVMKPQMzgSYIaLcGCFnCUH+ZLwbgF9EJAqjoTaPFh193oPehH5XyoTQvf0VtAqfc/7+ziwRmivRW8pBJJiyrhTSmaS2PoR/V1i225aVFWLKspcM9WdUXD9r0fo4T7iz+EnFwk7cpm0FbFPjV3YfCYAd0NUMedspivI3N6Xl3Dg== X-Forefront-PRVS: 004395A01C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(189002)(377454003)(199003)(66066001)(42186005)(110136002)(189998001)(68736007)(2906002)(33656002)(86362001)(59896002)(97736004)(64126003)(4001350100001)(80316001)(2950100001)(77096005)(92566002)(7416002)(50466002)(117156001)(83506001)(106356001)(586003)(5660300001)(65806001)(23676002)(47776003)(3846002)(6116002)(101416001)(76176999)(230700001)(65956001)(54356999)(50986999)(4326007)(7846002)(8666005)(81166006)(36756003)(65816999)(81156014)(87266999)(305945005)(105586002)(7736002)(8676002)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR84MB0320;H:[192.168.142.190];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtUVTRQUjg0TUIwMzIwOzIzOnN5cTBhenI4YTRJeGRtT3VVbGNsWm81SEdl?= =?utf-8?B?NnYxVmp4a2J6bEd4MlZnVHp2YkFPbDk4M2ZVQmtvSUVqOE0yd0lRY2FZQXBQ?= =?utf-8?B?WWlsUWhwbHBQbWNqNHo4SlU1RmtXSjA5RWg5Rmsxd0J2azVKSVVHNFpDelIy?= =?utf-8?B?WEt4K0J6YUZCVk5qOGxZMW9iaW0rUi8xY2E4YTRNeTRGYlN5RDBuN1dORk9K?= =?utf-8?B?clRoOG1sdzhmenovNUtRZ0VHdVpvSnJWSnlwRFdIUlArenJpdlM1S2lWekVE?= =?utf-8?B?V0phZmowUHNPeWZzSGtrU3BzZng3dFJzb0p6NGZGajBLOWhjcUU4RmQ1SzhU?= =?utf-8?B?RVlzOG1PeDBiMC80cUxhQ2ZETmRGS1NhME81a3RvSmNhUWttSTNFU0sxbkJN?= =?utf-8?B?YldaaDZoZDlsVHUwaENGRGhoNDdDR3FoMlpvSGpzQ29KZThHTWdPQktkbnZY?= =?utf-8?B?LzZXNjZzSkxkUzFZRkpOdWVEOTRkcUNhT25jUCtBcnVVcU01OVVxam1ybGpa?= =?utf-8?B?bEx0MlQxaGMxeHZKaElDdDM4TlhaWWhNV2hDNkdoYkRSYWJCMGM5d0pPQ294?= =?utf-8?B?aVVqa1c5alh6VE5wT01KVXZ3aFRMUHNGMHA3bWk3Vkk4bXNLZUoxUU16VG5t?= =?utf-8?B?b2hYYThOYXRuazVrdVlNZGZqd01Pb1o3OXEvM2tZZEZVSXV3SWloVElLNEF0?= =?utf-8?B?blJhK0xlZUtxTVh2R1VaSWNXV29hTldvQ1F2aWl3ZHUyWlhHR1J1VGxXcFF4?= =?utf-8?B?SEtUQ1VRWEcxNFVVcnlHME43SnlldlBITlBTcC9vYnI0MXRzNGVGMjJRaUhF?= =?utf-8?B?R0k4cmExQVNtWE1JK2JQczhYaEl6Y2U0WEw2ZmJmbjNrQUpmTVF2cjJBLzNE?= =?utf-8?B?VzFsWGtCTnFPSWsrVkd2Q25ZSXh5UTd2N0FZeExPNEFmM2doTWkxKy9WeTRy?= =?utf-8?B?cWFhdDJFYU8rWG9acDB5aEpvcWNnOUVQMEVQSFl5QkVzM1BrUmNiVm1lVzRB?= =?utf-8?B?OHZLZXIwUSsvUmV4RTh3S2s2QkVuSVQ3NnpBRzZQaHUvbXZMUkkyY1AzY1FX?= =?utf-8?B?Z3ZWcU5FVVd2eG1FaVBiUVlVb09tVXlJNkdWWWVCWWpqY2FkVXZXZEE3WElJ?= =?utf-8?B?aEh5dUtKMmtMQ1lNSU1GWG5GRjNuN2dEZGJEamxFUVZQaU8yRkNyMkJRS0FZ?= =?utf-8?B?azJnQVloOTJ4bWtDZ2xKTmo3UEFSb3ZHWXdzUll5Q2sxVTFVdTJYZGdDT2ZF?= =?utf-8?B?K2NLK0NOd2VkOTBiaUJCcEt3MnpudmJ4Q3ZGd0wvTzJOdGViY1ZkZ0pvMVV2?= =?utf-8?B?WWJEN0pSNGFnL285ZWZ4ZUI0ZTA3N0pMTUNCWWMrN0NIcXhiQmJRL1VwOHhM?= =?utf-8?B?SlExUWJheUZMZGdyZVJxL043YzlrWXY2ZjJ0V3NucXg4cDNoNkd3anoraEJQ?= =?utf-8?B?S25uOVN0VnM3ay9DUnVSZEVNUzJQSW1rYTlBSFpNT2Z1VGw4MWdBMlpQS1Nh?= =?utf-8?B?ZzlTZ09IeUd1amZyY096Vi9qY3ZhZGRvOC9Tc0lvTjN2dnZJcVFVLzQxOXdi?= =?utf-8?B?cmVhZzFHSG9jQjVGaEhuNEVBYm1VUTl5QjhDTmVuYXp5VXJ3RFRrbHhJWU5n?= =?utf-8?B?TUNhOWU0bmRzYzJCR2lOVUIyMWlFL3Z5OGhweTZ5ZVd2SzdWM1ZCNVdETTFC?= =?utf-8?B?ZFhyc01uOHBxS1VSSlVqZHJkWSsvQzVQVWVSWVRrTHp3VVUrd1FvczhIK0J0?= =?utf-8?B?OXdsVWowV2crTzBNMTF4YmNpOUc4MWE2aVBqeDhqV0ZJWHptSHpra3lVYVgw?= =?utf-8?Q?mtrYzr0+1jD6p?= X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0320;6:Fprt/8e+559fUa8KubLjYR/NtwCVRWsCZuDMA8HjqTAUKrDcwaBaX7plkLTIWwvjkMQt5yRYjLzSFN1IMymHnQdbnbKcIQEQRNXxnTTaoDPy19QFxjGHGJrAZO99AKoAmTHx4SuNM2+OUEYrb8I3N/CGBtHUK6UnmiflXDCJKCPPoI5rIW0FHV+OCSD5LBqg9Z/us526V5q4goFRCxkNNssNldrsQBAyTwideSTb3+4p0kOGTUkg6LyOCBbcx7oOb6RQ3kvi04b2y7VnhqnsfDL1MyOsD9wXkp1tL3RLL5z5ll6i7s4iKmGpn7uA0Q0xgaAf8gp5FP5y1CW67clPVQ==;5:FkxahQW1W/ehwsEvokiK45wes2w0BMUvzCaC4sznvyEDrPnHhItdI2C4YtyeUb2aK846ByTKWs092JjmtvZf2a7HMUbidZz6FMPDObAN4vLfxByOuBdHdF6QpIHSpqsYpwWGlz+HE45eY9y7uto3iw==;24:1TKTeE30LtUlVOLf6wbgjxlsKrY3ENOHnU7wzUhGY0q6/QvI0AYw8nIKQSvXSwhCbaSb6LhEGarNce8R3qrlge7i7iiy19wOIExWFEOp70o=;7:YM4diFmNLZy1ISIo0gTx01kEMHlvYZgRBWUhwXqnyl0Wk/xZb4cIF72Qbb8p3w1SVWtFO8RlAZX6Uar4aWKB6x77ii+LjKRjUTv4rulynctIVocTipOyOh0dRaH96zULP2QWYoHY6vz856y4AD2TXatFIjjz4CrriTU8J6csSFyFYUcOQVlPV8kKVxesB2b0+tlOGHmcJEU11o31rVHxSkZP8+WK3u/UTXfKSQaKgnzGivnUUAdMNSOTKxz5N8sA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2016 19:55:57.0317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0320 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/2016 08:46 AM, Peter Zijlstra wrote: I have 2 more comments about the code. 1) There are a couple of places where you only use 0x3 in mutex.c. They should be replaced by the symbolic name instead. 2) We should make __mutex_lock_slowpath() a noinline function just like __mutex_lock_killable_slowpath() or __mutex_lock_interruptible_slowpath(). Cheers, Longman