From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758372AbcHWWHC (ORCPT ); Tue, 23 Aug 2016 18:07:02 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:53567 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758202AbcHWWG7 (ORCPT ); Tue, 23 Aug 2016 18:06:59 -0400 Message-ID: <57BCC8F0.4000803@ni.com> Date: Tue, 23 Aug 2016 17:06:40 -0500 From: Xander Huff User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Florian Fainelli , Christophe Leroy , "David S. Miller" CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, brad.mouring@ni.com, nathan.sullivan@ni.com Subject: Re: [PATCH] net: phy: micrel: remove suspend/resume References: <20160823111344.25FF41A2459@localhost.localdomain> <2ee9441d-1b3b-de6d-691d-b615c04c69d0@gmail.com> In-Reply-To: <2ee9441d-1b3b-de6d-691d-b615c04c69d0@gmail.com> X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/23/2016 05:06:40 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/23/2016 05:06:40 PM, Serialize complete at 08/23/2016 05:06:40 PM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8; format=flowed X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-23_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/23/2016 2:03 PM, Florian Fainelli wrote: > +others, > > On 08/23/2016 04:13 AM, Christophe Leroy wrote: >> In ERRATA DS80000700A dated 05 May 2016, Microship recommends to >> not use software power down mode on KSZ8041 family. > > s/Microship/Microchip/ > >> They say they have no plan to fix this ERRATA in future releases. > > The errata applies to specific revisions, is this revision present in > the lower 4 bits of the MII_PHYSID2 register such that it could be used > to key the disabling of the power down? > >> >> http://ww1.microchip.com/downloads/en/DeviceDoc/80000700A.pdf >> >> Signed-off-by: Christophe Leroy >> --- >> drivers/net/phy/micrel.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c >> index 053e879..f456c55 100644 >> --- a/drivers/net/phy/micrel.c >> +++ b/drivers/net/phy/micrel.c >> @@ -837,8 +837,6 @@ static struct phy_driver ksphy_driver[] = { >> .get_sset_count = kszphy_get_sset_count, >> .get_strings = kszphy_get_strings, >> .get_stats = kszphy_get_stats, >> - .suspend = genphy_suspend, >> - .resume = genphy_resume, >> }, { >> .phy_id = PHY_ID_KSZ8041RNLI, >> .phy_id_mask = MICREL_PHY_ID_MASK, >> @@ -856,8 +854,6 @@ static struct phy_driver ksphy_driver[] = { >> .get_sset_count = kszphy_get_sset_count, >> .get_strings = kszphy_get_strings, >> .get_stats = kszphy_get_stats, >> - .suspend = genphy_suspend, >> - .resume = genphy_resume, >> }, { >> .phy_id = PHY_ID_KSZ8051, >> .phy_id_mask = MICREL_PHY_ID_MASK, >> > > It doesn't appear that KSZ9031 is affected by this errata; no mention of suspend: http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9031MNX_Errata_Rev%20A_A2_032515.pdf -- Xander Huff Staff Software Engineer National Instruments