From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754249AbcHXIjQ (ORCPT ); Wed, 24 Aug 2016 04:39:16 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:33960 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754126AbcHXIjH (ORCPT ); Wed, 24 Aug 2016 04:39:07 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-90-57bd5cfc04b1 Content-transfer-encoding: 8BIT Message-id: <57BD5CFB.5050500@samsung.com> Date: Wed, 24 Aug 2016 17:38:19 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Stephen Boyd , Sylwester Nawrocki Cc: tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> In-reply-to: <20160824044346.GR6502@codeaurora.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsWyRsSkUPdPzN5wg9vHBC0m3rjCYvH6haFF /+PXzBabHl9jtfjYc4/V4vKuOWwWM87vY7K4eMrV4vCbdlaLH2e6WSxW7frD6MDt8f5GK7vH 5b5eJo+ds+6ye2xa1cnmsXlJvUffllWMHp83yQWwR3HZpKTmZJalFunbJXBl3JhYWjCBp2L9 lMtsDYxnOLsYOTkkBEwkVu6bzw5hi0lcuLeerYuRi0NIYAWjREvPCzaYouUfVzBBJJYySvza 94oJJMErICjxY/I9li5GDg5mAXmJI5eyQcLMAuoSk+YtYoaof8AoseLWG0aQGl4BLYnOFZkg NSwCqhIzmr+DjWEDCu9/cQNsF7+AosTVH4/BykUFIiS6T1SChEUEwiSur37FDjKSWeAno8Sp xjnMIAlhgUSJR88uQt32m0niSc8CsASngLFE27+zLCAJCYFeDolTp/ezQWwWkPg2+RDY0RIC shKbDjBDPCkpcXDFDZYJjOKzkLw2C+G1WUheW8DIvIpRNLUguaA4Kb3IUK84Mbe4NC9dLzk/ dxMjMIJP/3vWu4Px9gHrQ4wCHIxKPLwX7u0JF2JNLCuuzD3EaAp0xERmKdHkfGCayCuJNzQ2 M7IwNTE1NjK3NFMS51WU+hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVFLqH1xdnv6V4WN s5KSjMQS7F1td4RnWgZvj4ud/V9fx2F7yrmzX+LmfXZ6Osn585RYf2b5vwtOxJ7mudwXoWsj bcERUSXSK6OpZ3n8flLqEscnd6wXbuTXUzF/fXJD09Z3NUF5a6QemAlO0Zy1qDjlc4dmX2ds cqG865N1ymu16/W32DHKK7EUZyQaajEXFScCAE9ZuDfbAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsVy+t9jAd0/MXvDDdZt5LaYeOMKi8XrF4YW /Y9fM1tsenyN1eJjzz1Wi8u75rBZzDi/j8ni4ilXi8Nv2lktfpzpZrFYtesPowO3x/sbrewe l/t6mTx2zrrL7rFpVSebx+Yl9R59W1YxenzeJBfAHtXAaJORmpiSWqSQmpecn5KZl26r5B0c 7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdKKSQlliTilQKCCxuFhJ3w7ThNAQN10LmMYI Xd+QILgeIwM0kLCGMePGxNKCCTwV66dcZmtgPMPZxcjJISFgIrH84womCFtM4sK99WxdjFwc QgJLGSV+7XsFluAVEJT4MfkeSxcjBwezgLzEkUvZIGFmAXWJSfMWMUPUP2CUWHHrDSNIDa+A lkTnikyQGhYBVYkZzd/BxrABhfe/uMEGYvMLKEpc/fEYrFxUIEKi+0QlSFhEIEzi+upX7CAj mQV+MkqcapzDDJIQFkiUePTsIhPErt9MEk96FoAlOAWMJdr+nWWZwCg4C8mpsxBOnYXk1AWM zKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgpPEM+kdjId3uR9iFOBgVOLh/cG4N1yI NbGsuDL3EKMEB7OSCG9hBFCINyWxsiq1KD++qDQntfgQoynQsxOZpUST84EJLK8k3tDYxMzI 0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxSDYyd39Vydz5Z88h706HJRuJvdzDE 3WrUk969b7ZYk/06xoAfgesTt/Rf5vnM+0TxfZOgO2d54ZdlKww/vlCdeJT7iQhbzrRi9Zey 2qvv+XieSl0stnvNgeC/jc58Yt37Nm/95fM7N8/k0p7nzl73bzQE3ctYkl6fraf8qZIleubR vbunTrulx22rxFKckWioxVxUnAgARCHEdigDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 08월 24일 13:43, Stephen Boyd wrote: > On 08/23, Sylwester Nawrocki wrote: >> On 08/23/2016 04:35 AM, Chanwoo Choi wrote: >> I checked stripped object files and it seems with the patch there >> is some saving of the kernel image size. Exactly 784 bytes, which >> makes zImage smaller by 480 bytes. >> >> The patch increases .init.rodata section size by 780 bytes but >> decreases .init.text section size by 1564 bytes. Looks like >> a static initializer is cheaper. >> >> $ ls -l drivers/clk/samsung/clk-exynos5260.o >> >> < -rw-rw-r-- 1 snawrocki snawrocki 29100 Aug 23 11:35 drivers/clk/samsung/clk-exynos5260.o >> --- >>> -rw-rw-r-- 1 snawrocki snawrocki 28316 Aug 23 11:32 drivers/clk/samsung/clk-exynos5260.o >> >> >> The section size differences are as below: >> 15c15 >> < 3 .init.text 000006b8 00000000 00000000 00000034 2**2 >> --- >>> 3 .init.text 0000009c 00000000 00000000 00000034 2**2 >> 25c25 >> < 8 .init.rodata 00003f6c 00000000 00000000 00002f20 2**2 >> --- >>> 8 .init.rodata 00004278 00000000 00000000 00002904 2**2 >> >> So the saving is rather insignificant but the patch doesn't make >> things worse and I'd say it might be worth applying. >> > > Sounds good. This sort of information should be in the commit > text though. Talking about const doesn't make any sense to me. Do you mean that 'const' is initconst secion? If possible, could you explain the anything why you don't make sense about 'const'? -- Best Regards, Chanwoo Choi