From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755839AbcHXWAi (ORCPT ); Wed, 24 Aug 2016 18:00:38 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:59395 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753184AbcHXWAh (ORCPT ); Wed, 24 Aug 2016 18:00:37 -0400 Message-ID: <57BE0E67.8060700@ni.com> Date: Wed, 24 Aug 2016 16:15:19 -0500 From: Xander Huff User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sergei Shtylyov , f.fainelli@gmail.com CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brad.mouring@ni.com, Nathan Sullivan Subject: Re: [PATCH] phy: request shared IRQ References: <1472061216-11111-1-git-send-email-xander.huff@ni.com> In-Reply-To: X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/24/2016 04:15:18 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/24/2016 04:28:19 PM, Serialize complete at 08/24/2016 04:28:19 PM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8; format=flowed X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-24_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/2016 1:41 PM, Sergei Shtylyov wrote: > Hello. > > On 08/24/2016 08:53 PM, Xander Huff wrote: > >> From: Nathan Sullivan >> >> On hardware with multiple PHY devices hooked up to the same IRQ line, allow >> them to share it. > > Note that it had been allowed until my (erroneous?) commit > 33c133cc7598e60976a069344910d63e56cc4401 ("phy: IRQ cannot be shared"), so I'd > like this commit just reverted instead... > I'm not sure now what was the reason I concluded that the IRQ sharing was > impossible... most probably I thought that the kernel IRQ handling code exited > the loop over the IRQ actions once IRQ_HANDLED was returned -- which is > obviously not so in reality... > > MBR, Sergei > Thanks for the suggestion, Sergei. I'll do just that. -- Xander Huff Staff Software Engineer National Instruments