From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758427AbcHYHj1 (ORCPT ); Thu, 25 Aug 2016 03:39:27 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:35211 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758078AbcHYHil (ORCPT ); Thu, 25 Aug 2016 03:38:41 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79cb6d000006cfe-c3-57be9e16b20b Content-transfer-encoding: 8BIT Message-id: <57BE9E16.7090309@samsung.com> Date: Thu, 25 Aug 2016 16:28:22 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Stephen Boyd Cc: Sylwester Nawrocki , tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> <57BD5CFB.5050500@samsung.com> <20160825001109.GO19826@codeaurora.org> In-reply-to: <20160825001109.GO19826@codeaurora.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsWyRsSkQFds3r5wgzdNKhYTb1xhsXj9wtCi //FrZotNj6+xWnzsucdqcXnXHDaLGef3MVlcPOVqcfhNO6vFjzPdLBardv1hdOD2eH+jld3j cl8vk8fOWXfZPTat6mTz2Lyk3qNvyypGj8+b5ALYo7hsUlJzMstSi/TtErgyTrccZi94wFXR +/05UwPjKY4uRk4OCQETiVMrtzNB2GISF+6tZ+ti5OIQEljBKPHv9hQ2mKJtN74yQyRmMUrc b5rICJLgFRCU+DH5HksXIwcHs4C8xJFL2RCmusSUKbkQ5Q8YJTp3dTJBlGtJLHz6EMxmEVCV eNi9FWwMG1B8/4sbYLv4BRQlrv54zAgyR1QgQqL7RCVIWARo5PcdJ8FKmAVWMEn8+WAEYgsL JEo8enaRCWLXEWaJv7uaWEESnEA3P5wzlR0kISHQyiFx+tpEFojFAhLfJh8Cu1lCQFZi0wFm iB8lJQ6uuMEygVF8FpLPZiF8NgvhswWMzKsYRVMLkguKk9KLjPSKE3OLS/PS9ZLzczcxAuP3 9L9nfTsYbx6wPsQowMGoxMO7Y9XecCHWxLLiytxDjKZAN0xklhJNzgcmibySeENjMyMLUxNT YyNzSzMlcd4EqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgF+1w19MrF+ZJrxOqn2PvH X2v2OsvIpR0yaUMuo9QuqZjdn7IM/ARUfp4J0f3h3mFtLXL6789CxQN51g55zK2lCvIzdE75 t+0TbCyten3ZvyFobpma3borkyWMEn+xLz+3IWYl479yyyTBxqXOi/pM9LUXqLUVLb8dGsQs 4lf/Z82m36s2KbEUZyQaajEXFScCAIKFAK/aAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsVy+t9jQV2xefvCDQ6flbWYeOMKi8XrF4YW /Y9fM1tsenyN1eJjzz1Wi8u75rBZzDi/j8ni4ilXi8Nv2lktfpzpZrFYtesPowO3x/sbrewe l/t6mTx2zrrL7rFpVSebx+Yl9R59W1YxenzeJBfAHtXAaJORmpiSWqSQmpecn5KZl26r5B0c 7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdKKSQlliTilQKCCxuFhJ3w7ThNAQN10LmMYI Xd+QILgeIwM0kLCGMeN0y2H2ggdcFb3fnzM1MJ7i6GLk5JAQMJHYduMrM4QtJnHh3nq2LkYu DiGBWYwS95smMoIkeAUEJX5MvsfSxcjBwSwgL3HkUjaEqS4xZUouRPkDRonOXZ1MEOVaEguf PgSzWQRUJR52bwUbwwYU3//iBhuIzS+gKHH1x2NGkDmiAhES3ScqQcIiQCO/7zgJVsIssIJJ 4s8HIxBbWCBR4tGzi0wQu44wS/zd1cQKkuAEuv/hnKnsExgFZyG5dBbCpbMQLl3AyLyKUSK1 ILmgOCk91ygvtVyvODG3uDQvXS85P3cTIzhFPJPewXh4l/shRgEORiUeXg3efeFCrIllxZW5 hxglOJiVRHgrZgCFeFMSK6tSi/Lji0pzUosPMZoCvTqRWUo0OR+YvvJK4g2NTcyMLI3MDS2M jM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cBYsneV8RxHnydTbvex5v3zSp/0lnvfi4Bp UkVF0gyufN/Ox8180/bmmans/vSV0bM/f7x75O2VfW/vSjE+ajfs+hnz+z7bsZtWL8Sa3k08 unzy5fvbL/3ldd9nVR1pz7p10nENuR3ShlE3Pr/TfSK77mdj+az+J1tkk25XNN2InMT0S/SL zONPCUosxRmJhlrMRcWJANhlOGInAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 2016년 08월 25일 09:11, Stephen Boyd wrote: > On 08/24, Chanwoo Choi wrote: >> On 2016년 08월 24일 13:43, Stephen Boyd wrote: >>> On 08/23, Sylwester Nawrocki wrote: >>>> So the saving is rather insignificant but the patch doesn't make >>>> things worse and I'd say it might be worth applying. >>>> >>> >>> Sounds good. This sort of information should be in the commit >>> text though. Talking about const doesn't make any sense to me. >> >> Do you mean that 'const' is initconst secion? > > No. Marking it as initconst in the patch is correct. OK. > >> If possible, could you explain the anything >> why you don't make sense about 'const'? >> > > I'm just saying that the reasoning to move it from the text > section to the data section shouldn't be because of const. There > should be better reasons to do this, like size benefits. > As I already said, the samsung_cmu_register_on() requires the 'const' type argument for 'struct samsung_cmu_info'. So, I defined the instance on the out of the exynos5260_clk_aud_init() as following: static const struct samsung_cmu_info aud_cmu __initconst = { How can i add the 'const' keyword and '__initsecion' to the "struct samsung_cmu_info aud_cmu" in the "static void __init exynos5260_clk_aud_init(struct device_node *np)"? -- Best Regards, Chanwoo Choi