From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759981AbcHYQd0 (ORCPT ); Thu, 25 Aug 2016 12:33:26 -0400 Received: from mail-sn1nam01on0116.outbound.protection.outlook.com ([104.47.32.116]:37248 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759682AbcHYQdN (ORCPT ); Thu, 25 Aug 2016 12:33:13 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57BF1DC0.60308@hpe.com> Date: Thu, 25 Aug 2016 12:33:04 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Peter Zijlstra CC: Jason Low , Davidlohr Bueso , Linus Torvalds , Ding Tianhong , Thomas Gleixner , Will Deacon , Ingo Molnar , Imre Deak , Linux Kernel Mailing List , Tim Chen , "Paul E. McKenney" , Subject: Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex References: <20160823124617.015645861@infradead.org> <20160823161750.GD31186@linux-80c1.suse> <1471970103.2381.51.camel@j-VirtualBox> <1472001223.2381.96.camel@j-VirtualBox> <20160825154331.GI10138@twins.programming.kicks-ass.net> In-Reply-To: <20160825154331.GI10138@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.247] X-ClientProxiedBy: BN6PR15CA0019.namprd15.prod.outlook.com (10.172.204.157) To TU4PR84MB0319.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.29) X-MS-Office365-Filtering-Correlation-Id: 098a3c55-ca6e-4d60-f065-08d3cd05801f X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;2:qPMPtzwrNNpL+rJF5Ov4QbTaXgF8lNiF/pu+Urgg6fsbSrSEjtg75+92rskjNOMc1Wqp+qrNj73U69CJrlnVFYjvisfYKQsste37FBMWHmqpd7IGnQsvHEz2h3vecyuk4fMP7XtpVfZuRASilv3duLr11rHEsFEN7CaWLgBqUWR26ZTwL709D0juTfM4snSp;3:vUluE+LwWpH0xw3Z+BiRky6TBFf0ey0aemVPu5zjOFWH5P8JkRrOsqlziS1Ui5oSVRaQzgljSVr0S8K0lavWgB3J3rgsbbrOVx1T2SaV365jxXnUFwxzp39To7Rt1iTu;25:Us1wVDMOoYECoDQFtZpIErOcbGz+Ln0ZuMFBWRj/zRNPLndMPEPKYeVhZuQIgs6l0IODm8FY1bXj+Jknn7/fWUnCfgqKhQyVbBSkIKnXErmfjIMoSmIIsbJAs/ybSKs/enPOsp2/UF6YjT9ctHU4b4OtohOZFnwHuJWcLhDxDCCh9ZoG0VjL21yUaFuNvm9yxxlODR8nWvLbbTO8k7NVwdKjfiQJxTT4HwTxSGM2OktFQs/aw6BW2Ya5q4GvnA74JDghflepFWpzH/XUc2/fsNSNdxEEPQx+dygNO1eSqH04S2VPDgnOelHhgHmfmkWfspW0JunZC5Q3WH3w5yijgQFXsonYxLshGMrxIf0PBUeNfHjlqrzcXWYUynT/y5gbKSTtLXWMoQ/Cd+olBd9dA+awrtFAN8378+eecCRWDqw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0319; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;31:585O9WC6LAhQ1womIteKt8Bs9gKZKhaZkv/NcopH18bP+8ouxV8k0SPkQFuFWQ8fdPFll3Qcvcx/58lXLlmXu9NefBahRDEenyJXmhWitWmr+Y4UNnES6YZg+j7aNiCD5Dd3Ckv1Pf0JUgSIIrpgelRqgKmuvlckwHTm9hu3BV5D8nopt0yqq1p6UqqKFdjp2pTktFlSgl9s2nlGjspTfgPen4sSdIryR1pUfJI0u2o=;20:5l0GvZWc5igCVNxF9zkQc/eXjtbEHA8KBCN3wRS26C97VfMNBu4B1UMR9cSzyRemsB/UgwQJv2uc7S9wjegVrd9QTQVOyaN1iDGIsVEoROd9/t7WE72TzC7BOFdFS9I2vFK90EWv1xaIWVcnjxqfWNkiYQukK58OgmKBd3ft+dZXRE9nh33Pz+6qjOoCiPPrZuPPXzhq31gv/hXcWwtAzu9RqwURN4jgaSgSDNPO3dhQis2GnBl9MiUFEApKgceLbXzV1dLaiyaGBrHU4qcginvOLW9Ds8DVMy5aBMhO+k24yNidDGa145FRQXs9T35Lr963rn7br7+EoIzcy055ggAMy2+2Zixdy8E8pPAZmJNh8sXc8PEKpnd0exCgWeLP47HuE3ita2eozxpJUhvtONWT1SPe47OlvK1lJaZUpdafpVfZmVkswAXyWkk3apVhbeFubjlu7Xok2043meXYtFMLX6g5eFJjE2LEaXSSCb2BnblTlXOlR8HeufO2DyWb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:TU4PR84MB0319;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0319; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;4:ZrLu7OHjIUmB6IoikjQ9Qdch4uGVTFnSNc1/Eq7cHr2f9ZCiGGg4WYbkuJ0bvEdioRDDQutzd53SDGI2TgC/FXC09Ic7UdN91/taL3GlmSjVGBY3nCIxnjHnVrrMd20OEwNDYrSSVekz/3HleEZtTlL26P/+csX1R8ZrWsRF0iVbwlMFjMaixsd0Z6StqxTnvicPIlzpjsZlZj24IjlfuTTDmDJkRIPTP/TqlxJnNqal9xH9/lPZm6mKKZOywHVJbiabZBTS4+QrjDx8I7NB5+Zm0Mx9PAFGGp11lUR+7ak6SdZW5M3wA0Eu/Whkrk59+i30HvIB07m5jlEJoQNCyL7ogimrpS3qnDkWzt0/eZHptbl/EIId9vZJD8paUpmSx0ZC5ev5ratqqoKZHQjpaw== X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(24454002)(189002)(199003)(305945005)(54356999)(83506001)(47776003)(65956001)(86362001)(76176999)(50986999)(65806001)(8676002)(81156014)(6116002)(230700001)(586003)(92566002)(81166006)(3846002)(65816999)(36756003)(4001350100001)(110136002)(2950100001)(2906002)(189998001)(23756003)(4326007)(42186005)(77096005)(93886004)(97736004)(64126003)(7416002)(50466002)(105586002)(5660300001)(106356001)(117156001)(7846002)(7736002)(8666005)(66066001)(68736007)(33656002)(101416001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR84MB0319;H:[192.168.142.192];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;TU4PR84MB0319;23:NKtx03eI74WuCE9IWPouw/GUASKQLiRlLvxuuKi?= =?iso-8859-1?Q?MopmukOok1qZx6qqS7XuNfoPEmJpoFpW3nv/IufgirBb0tcUQbej5YcLdm?= =?iso-8859-1?Q?tF3xTNEaFfnMoHLCaa0vEAPhENwJgmBcCzE3Y+5xHMJdBWHoaE6LecK26V?= =?iso-8859-1?Q?j/V4xNgJWAWTc5vLPg9uEfHyo+TDozPxSFLf54aQGYh0fybaY/eqxIB6Lo?= =?iso-8859-1?Q?rLA1AwF5WyaBeIe/483Ljn2tR5lKH8Y8hsNJUr2nUxNW+PBhaiDHTTzYqF?= =?iso-8859-1?Q?y87LQSxuPcMMAqbpjlQ1bbuQspaxr4LEWC975TY3uks6wYyB+coNOatn0F?= =?iso-8859-1?Q?0Ioj2uTAv6qylay9flSByMOzC9zQnWUTDGG1Cv/1AJ0cXxyS4dl25+0Z3k?= =?iso-8859-1?Q?xPKXtYMB+PD0RBpz8hEL+e6SNZ521iDB+Jcqr7d45rgZTnYLL0uAqx8+Jm?= =?iso-8859-1?Q?RfARI2+Y2cVOrcDexPpEz9+I+YHagBxM1lTXnX3U2minbp9HBsbCF4pN8A?= =?iso-8859-1?Q?jn5YB/yzFVDVUpymeHW0K6qGLkBuDdYoqTcljKwHMT9kuvXkF8qdvqjjT1?= =?iso-8859-1?Q?u2k0WFg31hb4af16W8U1Q5TSWkWU+7Yjwf+CDwbCE/DNeS0K5c6UKKcnO/?= =?iso-8859-1?Q?dYkUv6DgYXrZOOH5ljh/nBZsP/Kiex6zRFqkcgCDmBmUR329ED4b4lAlLJ?= =?iso-8859-1?Q?bumVrHeQNY+EXPz+8uimPrXFgx96/v6PaNQ0qE68M28ykn7L24R4PynDUu?= =?iso-8859-1?Q?DKKTwSZ3ac72MVj3nj8GQCmfkM8UgvTltY6FmmEIXEb82V4+DNx67csFHk?= =?iso-8859-1?Q?N4qIguem4Q6SIi2WcY7yrBGOnDOqsTZjfZEeNwC5WcwIaY1TG/Kyz6jnBQ?= =?iso-8859-1?Q?ME7vbk9VBJWb2mHnaworM/nPA1xP+4vU0WVMP70s5IA1UkOJyU/gnGjwKH?= =?iso-8859-1?Q?ktRDC3SbzjcBYHfCBt+1cgXZxeAG0b5Is4PfjwJ1sDoL/GCOhamSuhNAZr?= =?iso-8859-1?Q?3KcH43gL3Z3fqs93oYiV51ecEObnDqWak+IiIKTxrGmunWLpjnsEAVGO5W?= =?iso-8859-1?Q?pgQ9GlL8sZBepWfjsIofyFpkyJ7Rs6e8ZDHNelzlAsrKuD5+a0pJNMOcXH?= =?iso-8859-1?Q?8x1yGvzj6LaFGT+u3Y+Yvuo6KDOwRF1MoXC3dQlJtc8qgbruCI2W2DGtsK?= =?iso-8859-1?Q?C4POZRKSPg3nA9yF7n0MlKfKtXztFNiF2d31GjgtJlKer8nG0U66mTkSAo?= =?iso-8859-1?Q?33O2WPGiB5tNmgG91VHG+zb70+29x/j2yl2UPUkcabGvTMRE4GD/i63cEK?= =?iso-8859-1?Q?6MvPyyKLCz7L4lNW2Q0VMy//H000ANsK8QXcLieW8RNDg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0319;6:7Ij70Rnawp7IkBcuUMEqgBppHWpPosnJBy4CgnYD+VjUdeidKj2DQX5nxpYI39tuBPznXFflugYNoiU690HT4a68vDiuwRQgnRAzscXGSYJU96PN767U/bbzZEU/Z9flAAAOfT8GQSQfuVCZSuCZTvpAksRMa2FOWB6IkugODRQ07Yi8R+yf9eKiHMwv68R9C0N0Tp1x3E6yzGoGo9gD9gBDmJaQKGihSNmuRyHD+Q3hYSNQAmvwiEFZX42+a8InrmILheBiDyY4iMW85U5h9XpIzvSAQmfmMgKjXBdrac9nK3mJRZvL5PbB6thF6I0QU38EYoY3Kb2Dd/IUkmUo5Q==;5:gVpY8/9FlkBxuhhKTVVNwj4ah/0MsdeKwls1IaSE1ckpI0vf+F0knsZgqUHK+lLMCKkd8uwbZjzl8SM8/26LTDohTqJAFal4E6DGTCWra9Vc1PexfqlwQJgsCLJsXG0Ir1lorrL9Stpa03pzT1w2FA==;24:oB7lsR73FQXJe+oydTPx0yPoBG+18OCIi99M9JOUSyTcbrqXw8Edydsk+bpVmNWwAImjU3rsFFbaal7Zt2lWXJQ8u2Y4UKxLURirzYfhGEw=;7:/fxD20I4AIG9fyXRghHeNEbAWgtzBexl5QvWu19lnBE3lhTPXpfrmubvkyTWlGzhc9Wr/KfEwooyd+QaXOa4+YL5uBYccgEQC2V0VjhqYQW0W/K7hMyXUNegMftkSIJ2TF7vFCnMugrTl//3GvtW3pFtq2HWaL8ILOiybqCs6ILDyUYNhdOy/7SHhO6sEX6e6eG1fhljO7ngOocpKCQQ1xnQqDH3QtNsUwPcYHrtmUo6ML3n+OnZaLR3h57X8O4p SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 16:33:08.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0319 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 11:43 AM, Peter Zijlstra wrote: > On Tue, Aug 23, 2016 at 06:13:43PM -0700, Jason Low wrote: >> I tested this patch on an 8 socket system with the high_systime AIM7 >> workload with diskfs. The patch provided big performance improvements in >> terms of throughput in the highly contended cases. >> >> ------------------------------------------------- >> | users | avg throughput | avg throughput | >> | without patch | with patch | >> ------------------------------------------------- >> | 10 - 90 | 13,943 JPM | 14,432 JPM | >> ------------------------------------------------- >> | 100 - 900 | 75,475 JPM | 102,922 JPM | >> ------------------------------------------------- >> | 1000 - 1900 | 77,299 JPM | 115,271 JPM | >> ------------------------------------------------- >> >> Unfortunately, at 2000 users, the modified kernel locked up. >> >> # INFO: task reaim:<#> blocked for more than 120 seconds. >> >> So something appears to be buggy. > So with the previously given changes to reaim, I get the below results > on my 4 socket Haswell with the new version of 1/3 (also below). > > I still need to update 3/3.. > > Note that I think my reaim change wrecked the jobs/min calculation > somehow, as it keeps increasing. I do think however that the numbers are > comparable between runs, since they're wrecked the same way. The performance data for the 2 kernels were roughly the same. This was what I had been expecting as there was no change in algorithm in how the slowpath was being handled. So I was surprised by Jason's result yesterday showing such a big difference. Cheers, Longman