From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756968AbcHZCWc (ORCPT ); Thu, 25 Aug 2016 22:22:32 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:34561 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbcHZCWZ (ORCPT ); Thu, 25 Aug 2016 22:22:25 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-e1-57bfa7d26dce Content-transfer-encoding: 8BIT Message-id: <57BFA7D2.4000807@samsung.com> Date: Fri, 26 Aug 2016 11:22:10 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jisheng Zhang , myungjoo.ham@samsung.com, kyungmin.park@samsung.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / devfreq: fix Kconfig indent style References: <20160825120614.511-1-jszhang@marvell.com> In-reply-to: <20160825120614.511-1-jszhang@marvell.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRsSkQPfS8v3hBpe+mli8O76bxeJs0xt2 i8u75rBZfO49wmhxu3EFmwOrx+SFF5k9+rasYvT4vEkugDmKyyYlNSezLLVI3y6BK+Pg0nuM BY/4KtbOf8rUwHiNu4uRk0NCwETi6IOTbBC2mMSFe+uBbC4OIYEVjBLnpl5jgSma/aCdBSKx lFHi3ey3TCAJXgFBiR+T7wElODiYBeQljlzKBgkzC6hLTJq3iBmi/gGjxMu506HqtSQ2fD8A NpRFQFVi44KDYDYbUHz/ixtgV/ALKEpc/fGYEWSmqECERPeJSpCwiECcxNKmY4wQ860kXn/s ZgexhQWsJXavXgQ2Rkigh1Hi+pxIEJtTwFzid9t2qMcOsUtsOigKsVZA4tvkQ2AnSwjISmw6 wAxRIilxcMUNlgmM4rOQPDYL4bFZSB5bwMi8ilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMw wk7/e9a7g/H2AetDjAIcjEo8vCf094cLsSaWFVfmHmI0BTpiIrOUaHI+MI7zSuINjc2MLExN TI2NzC3NlMR5FaV+BgsJpCeWpGanphakFsUXleakFh9iZOLglGpgzFl3OufXz8/z/XkmdDmu WeE7S3mal29UuaMOx9kPwetLT5rMUjXX276s/PXj3Y9TuBvuGj1zmHyxa9qrRpsppSo+h5YZ cF9c6O+TfeH8m0mfdCp/udr5aFVnp+Yoinedl41/UXHfW/llmedFHd6ARX7Gl2xzf3ivN/8f krrwp4B/qoXM2sc7lFiKMxINtZiLihMBlHHmtqsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsVy+t9jAd1Ly/eHGzRv1bd4d3w3i8XZpjfs Fpd3zWGz+Nx7hNHiduMKNgdWj8kLLzJ79G1ZxejxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhDWPGwaX3GAse8VWsnf+UqYHxGncXIyeHhICJxOwH7SwQtpjEhXvr 2boYuTiEBJYySryb/ZYJJMErICjxY/I9oCIODmYBeYkjl7JBwswC6hKT5i1ihqh/wCjxcu50 qHotiQ3fD4ANZRFQldi44CCYzQYU3//iBhuIzS+gKHH1x2NGkJmiAhES3ScqQcIiAnESS5uO MULMt5J4/bGbHcQWFrCW2L16EdgYIYEeRonrcyJBbE4Bc4nfbdvZJjAKzkJy6SyES2chuXQB I/MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k/NxNjOA4fia9g/HwLvdDjAIcjEo8vBX1+8OF WBPLiitzDzFKcDArifByLgUK8aYkVlalFuXHF5XmpBYfYjQFenUis5Rocj4wxeSVxBsam5gZ WRqZG1oYGZsrifM+/r8uTEggPbEkNTs1tSC1CKaPiYNTqoFxrsquj1W9vudLPSZoB0sFeGmp iV06t+pVdQLH2/tlV81OX3hwVDeu6Xuu7btJ9ju7noac0//GbbZMdrXhhs9Hl3f47ij8eOTn FA6O8I97f4upKyg0/W9Xm9zs9eXRiTMWLx0SnKYd2tHMm7kuILikbf+0gKAPfrLif04Icq5/ bt0h36/5/l2PEktxRqKhFnNRcSIAlPtKTPkCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jisheng, Looks good to me. But, you need to rebase it on latest devfreq.git because the related patch is already merged[1] for COMPILE_TEST. So, the merge conflict may happen. [1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8 If you resend it with rebase on devfreq.git, Feel free to add my reviewed-by tag: Reviewed-by: Chanwoo Choi On 2016년 08월 25일 21:06, Jisheng Zhang wrote: > Use tab rather than space to indent, and tab + two spaces to indent > help message. > > Signed-off-by: Jisheng Zhang > --- > drivers/devfreq/Kconfig | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index a5be56e..86d06ab 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -91,14 +91,14 @@ config ARM_EXYNOS_BUS_DEVFREQ > This does not yet operate with optimal voltages. > > config ARM_TEGRA_DEVFREQ > - tristate "Tegra DEVFREQ Driver" > - depends on ARCH_TEGRA_124_SOC > - select DEVFREQ_GOV_SIMPLE_ONDEMAND > - select PM_OPP > - help > - This adds the DEVFREQ driver for the Tegra family of SoCs. > - It reads ACTMON counters of memory controllers and adjusts the > - operating frequencies and voltages with OPP support. > + tristate "Tegra DEVFREQ Driver" > + depends on ARCH_TEGRA_124_SOC > + select DEVFREQ_GOV_SIMPLE_ONDEMAND > + select PM_OPP > + help > + This adds the DEVFREQ driver for the Tegra family of SoCs. > + It reads ACTMON counters of memory controllers and adjusts the > + operating frequencies and voltages with OPP support. > > source "drivers/devfreq/event/Kconfig" > > -- Best Regards, Chanwoo Choi