* [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1
@ 2016-08-26 6:22 Xing Zheng
2016-08-26 9:41 ` Shawn Lin
0 siblings, 1 reply; 3+ messages in thread
From: Xing Zheng @ 2016-08-26 6:22 UTC (permalink / raw)
To: linux-rockchip
Cc: dianders, jay.xu, huangtao, Xing Zheng, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Heiko Stuebner, Caesar Wang,
Brian Norris, Elaine Zhang, David Wu, Masahiro Yamada, devicetree,
linux-arm-kernel, linux-kernel
Dues to incorrect description in the TRM, the WDTs base address
should be fixed and swap them like this:
WDT0 - 0xff848000
WDT1 - 0xff840000
And, it is right that only WDT0 can generate global software reset.
We will update the TRM to fix it.
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index bc86e8c..f0f52c1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1002,9 +1002,9 @@
};
};
- watchdog@ff840000 {
+ watchdog@ff848000 {
compatible = "snps,dw-wdt";
- reg = <0x0 0xff840000 0x0 0x100>;
+ reg = <0x0 0xff848000 0x0 0x100>;
clocks = <&cru PCLK_WDT>;
interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1
2016-08-26 6:22 [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Xing Zheng
@ 2016-08-26 9:41 ` Shawn Lin
2016-08-26 10:49 ` Xing Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Lin @ 2016-08-26 9:41 UTC (permalink / raw)
To: Xing Zheng, linux-rockchip
Cc: shawn.lin, huangtao, Mark Rutland, Elaine Zhang, Heiko Stuebner,
devicetree, Catalin Marinas, Brian Norris, Will Deacon, dianders,
linux-kernel, Masahiro Yamada, Rob Herring, David Wu, jay.xu,
linux-arm-kernel, Caesar Wang
On 2016/8/26 14:22, Xing Zheng wrote:
> Dues to incorrect description in the TRM, the WDTs base address
> should be fixed and swap them like this:
> WDT0 - 0xff848000
> WDT1 - 0xff840000
>
> And, it is right that only WDT0 can generate global software reset.
> We will update the TRM to fix it.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index bc86e8c..f0f52c1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1002,9 +1002,9 @@
> };
> };
>
> - watchdog@ff840000 {
> + watchdog@ff848000 {
Just a nit, should we mark this explicitly as "watchdog0" ?
I still need to look up for which wdt you are using.:)
> compatible = "snps,dw-wdt";
> - reg = <0x0 0xff840000 0x0 0x100>;
> + reg = <0x0 0xff848000 0x0 0x100>;
> clocks = <&cru PCLK_WDT>;
> interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> };
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1
2016-08-26 9:41 ` Shawn Lin
@ 2016-08-26 10:49 ` Xing Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Xing Zheng @ 2016-08-26 10:49 UTC (permalink / raw)
To: Shawn Lin
Cc: linux-rockchip, huangtao, Mark Rutland, Elaine Zhang,
Heiko Stuebner, devicetree, Catalin Marinas, Brian Norris,
Will Deacon, dianders, linux-kernel, Masahiro Yamada, Rob Herring,
David Wu, jay.xu, linux-arm-kernel, Caesar Wang
Hi Shawn,
On 2016年08月26日 17:41, Shawn Lin wrote:
> On 2016/8/26 14:22, Xing Zheng wrote:
>> Dues to incorrect description in the TRM, the WDTs base address
>> should be fixed and swap them like this:
>> WDT0 - 0xff848000
>> WDT1 - 0xff840000
>>
>> And, it is right that only WDT0 can generate global software reset.
>> We will update the TRM to fix it.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> ---
>>
>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index bc86e8c..f0f52c1 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -1002,9 +1002,9 @@
>> };
>> };
>>
>> - watchdog@ff840000 {
>> + watchdog@ff848000 {
>
> Just a nit, should we mark this explicitly as "watchdog0" ?
> I still need to look up for which wdt you are using.:)
Done.
Thanks.
>
>> compatible = "snps,dw-wdt";
>> - reg = <0x0 0xff840000 0x0 0x100>;
>> + reg = <0x0 0xff848000 0x0 0x100>;
>> clocks = <&cru PCLK_WDT>;
>> interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>
>
--
- Xing Zheng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-26 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 6:22 [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Xing Zheng
2016-08-26 9:41 ` Shawn Lin
2016-08-26 10:49 ` Xing Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox