From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932543AbcH2CKK (ORCPT ); Sun, 28 Aug 2016 22:10:10 -0400 Received: from regular1.263xmail.com ([119.61.6.1]:46774 "EHLO regular1.263xmail.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752154AbcH2CKI (ORCPT ); Sun, 28 Aug 2016 22:10:08 -0400 X-Greylist: delayed 450 seconds by postgrey-1.27 at vger.kernel.org; Sun, 28 Aug 2016 22:10:07 EDT X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhangqing@rock-chips.com X-FST-TO: wxt@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhangqing@rock-chips.com X-UNIQUE-TAG: <6c7841fcb3065d801f27a614a21638f2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57C396D2.4090607@rock-chips.com> Date: Mon, 29 Aug 2016 09:58:42 +0800 From: Elaine Zhang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Shawn Lin , Ziyuan Xu , ulf.hansson@linaro.org, robh+dt@kernel.org, heiko@sntech.de CC: Mark Rutland , devicetree@vger.kernel.org, Catalin Marinas , Xing Zheng , Masahiro Yamada , Frank Wang , Brian Norris , Will Deacon , linux-kernel@vger.kernel.org, Douglas Anderson , linux-rockchip@lists.infradead.org, Jianqun Xu , David Wu , Shunqian Zheng , linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399 References: <20160827134103.28160-1-xzy.xu@rock-chips.com> <20160827134103.28160-3-xzy.xu@rock-chips.com> <2ab8ab94-fa4d-2cd6-5805-a92ac5f9697e@rock-chips.com> In-Reply-To: <2ab8ab94-fa4d-2cd6-5805-a92ac5f9697e@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2016 11:05 PM, Shawn Lin wrote: > On 2016/8/27 21:41, Ziyuan Xu wrote: >> Control power domain for eMMC via genpd to reduce power consumption. >> >> Signed-off-by: Elaine Zhang >> Signed-off-by: Ziyuan Xu >> > > It looks nice to me. But this should be merged after applying that[0] > as your patch will break bind/unbind test for sdhci-of-arasan on rk3399 > without it[0]. Moreover, Elaine should make sure that upstreamed > rockchip power domain stuff would not off pd for emmc, *otherwise*, I > should update my patch to make sure we update clkmul every time when > doing suspend 2 resume.. > It looks nice to me. I was going on to submit with other Pds. > > > [0]: https://patchwork.kernel.org/patch/9300971/ > >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index 32aebc8..71733d4 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -239,6 +239,7 @@ >> #clock-cells = <0>; >> phys = <&emmc_phy>; >> phy-names = "phy_arasan"; >> + power-domains = <&power RK3399_PD_EMMC>; >> status = "disabled"; >> }; >> >> @@ -611,6 +612,11 @@ >> status = "disabled"; >> }; >> >> + qos_emmc: qos@ffa58000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa58000 0x0 0x20>; >> + }; >> + >> qos_hdcp: qos@ffa90000 { >> compatible = "syscon"; >> reg = <0x0 0xffa90000 0x0 0x20>; >> @@ -739,6 +745,11 @@ >> }; >> >> /* These power domains are grouped by VD_LOGIC */ >> + pd_emmc@RK3399_PD_EMMC { >> + reg = ; >> + clocks = <&cru ACLK_EMMC>; >> + pm_qos = <&qos_emmc>; >> + }; >> pd_vio@RK3399_PD_VIO { >> reg = ; >> #address-cells = <1>; >> > >