From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755243AbcH2FoW (ORCPT ); Mon, 29 Aug 2016 01:44:22 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48624 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcH2FoU (ORCPT ); Mon, 29 Aug 2016 01:44:20 -0400 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 29 Aug 2016 11:13:43 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Aneesh Kumar K.V" , akpm@linux-foundation.org CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Use zonelist name instead of using hardcoded index References: <1472227078-24852-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1472227078-24852-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082905-0004-0000-0000-0000018C7166 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082905-0005-0000-0000-0000088FF7AE Message-Id: <57C3CB8F.9060501@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-29_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608290060 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2016 09:27 PM, Aneesh Kumar K.V wrote: > This use the existing enums instead of hardcoded index when looking at the Small nit. 'use' --> 'uses' > zonelist. This makes it more readable. No functionality change by this > patch. Came across this some time back, yeah it really makes sense to replace those hard coded indices. > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Anshuman Khandual