From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
mhiramat@kernel.org, wangnan0@huawei.com,
hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization
Date: Mon, 29 Aug 2016 13:39:34 +0530 [thread overview]
Message-ID: <57C3EDBE.7060709@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160826195452.GC13587@kernel.org>
On Saturday 27 August 2016 01:24 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu:
>>> +++ b/tools/perf/util/probe-finder.c
>>> @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, struct probe_finder *pf)
>>> return die_walk_lines(sp_die, probe_point_lazy_walker, pf);
>>> }
>>
>>> +static bool var_has_loclist(Dwarf_Die *die)
>> So, the variable 'die' cause the build to fail in multiple systems, I'm
>> renaming it to 'cu_die', there are some more problems when cross compiling it
>> to some arches, I'm trying to fix them all now:
> Fixed, please check:
>
> http://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/urgent&id=3866e3762da3291613dfb8b193885a8ed3836669
Thanks Arnaldo,
I've tested it. Looks fine to me.
-Ravi
> - Arnaldo
>
next prev parent reply other threads:[~2016-08-29 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:58 [PATCH 1/2] perf probe: Helper function to check if probe with variable Ravi Bangoria
2016-08-03 8:58 ` [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization Ravi Bangoria
2016-08-13 13:45 ` Ravi Bangoria
2016-08-25 12:30 ` Masami Hiramatsu
2016-08-18 9:17 ` Naveen N. Rao
2016-08-25 12:50 ` Masami Hiramatsu
2016-08-25 13:59 ` Jiri Olsa
2016-08-25 15:17 ` Arnaldo Carvalho de Melo
2016-08-25 15:44 ` Jiri Olsa
2016-08-26 19:30 ` Arnaldo Carvalho de Melo
2016-08-26 19:54 ` Arnaldo Carvalho de Melo
2016-08-27 0:27 ` Masami Hiramatsu
2016-08-29 15:10 ` [PATCH] perf probe: Move dwarf specific functions to dwarf-aux.c Ravi Bangoria
2016-08-29 22:53 ` Masami Hiramatsu
2016-08-30 8:39 ` [PATCH v2] " Ravi Bangoria
2016-08-30 14:10 ` Masami Hiramatsu
2016-09-05 13:27 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2016-08-29 8:09 ` Ravi Bangoria [this message]
2016-08-29 8:08 ` [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization Ravi Bangoria
2016-09-05 13:26 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2016-08-25 12:32 ` [PATCH 1/2] perf probe: Helper function to check if probe with variable Masami Hiramatsu
2016-09-05 13:26 ` [tip:perf/core] perf probe: Add helper " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C3EDBE.7060709@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox