From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932893AbcH2IJq (ORCPT ); Mon, 29 Aug 2016 04:09:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54501 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932213AbcH2IJo (ORCPT ); Mon, 29 Aug 2016 04:09:44 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization To: Arnaldo Carvalho de Melo References: <1470214725-5023-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1470214725-5023-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160826193027.GB13587@kernel.org> <20160826195452.GC13587@kernel.org> Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, mhiramat@kernel.org, wangnan0@huawei.com, hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Mon, 29 Aug 2016 13:39:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160826195452.GC13587@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082908-8235-0000-0000-000009134551 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005659; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00751054; UDB=6.00354915; IPR=6.00523843; BA=6.00004676; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012499; XFM=3.00000011; UTC=2016-08-29 08:09:42 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082908-8236-0000-0000-00003459D9D7 Message-Id: <57C3EDBE.7060709@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-29_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608290085 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 27 August 2016 01:24 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: >>> +++ b/tools/perf/util/probe-finder.c >>> @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, struct probe_finder *pf) >>> return die_walk_lines(sp_die, probe_point_lazy_walker, pf); >>> } >> >>> +static bool var_has_loclist(Dwarf_Die *die) >> So, the variable 'die' cause the build to fail in multiple systems, I'm >> renaming it to 'cu_die', there are some more problems when cross compiling it >> to some arches, I'm trying to fix them all now: > Fixed, please check: > > http://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/urgent&id=3866e3762da3291613dfb8b193885a8ed3836669 Thanks Arnaldo, I've tested it. Looks fine to me. -Ravi > - Arnaldo >