From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: pavel@ucw.cz, rafael.j.wysocki@intel.com, jlee@suse.com,
bp@alien8.de, yu.c.chen@intel.com
Subject: Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value
Date: Mon, 29 Aug 2016 17:08:08 -0400 [thread overview]
Message-ID: <57C4A438.6090800@redhat.com> (raw)
[My apologies for breaking threading. I'm not sub'd to LKML ...]
On Mon 2016-08-29 00:35:40, Chen Yu wrote:
>+ if (memcmp(result, buf, MD5_DIGEST_SIZE)) {
>+ pr_err("PM: e820 map conflict detected.\n");
>+ panic("BIOS is playing funny tricks with us.\n");
>+ }
This should have a better explanation. Perhaps
BUG("PM: BIOS e820 map conflicts with map from previous boot. S4/hibernate is
not supported on this platform. Please contact your hardware vendor.\n");
or
pr_crit(FW_BUG "BIOS e820 map conflicts with map from previous boot.");
BUG("PM: S4/hibernate is broken on this platform. Please contact your hardware
vendor for support.\n");
is more appropriate rather than having them filing a kernel.org BZ or
contacting an OS company with a bug that cannot be resolved in software. There
are some other instances in the kernel where we've told them to do the same,
and it is appropriate to do so here.
P.
next reply other threads:[~2016-08-29 21:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 21:08 Prarit Bhargava [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-28 16:35 [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value Chen Yu
2016-08-28 16:36 ` Pavel Machek
2016-08-29 4:59 ` Borislav Petkov
2016-08-29 7:15 ` Pavel Machek
2016-08-29 13:41 ` Borislav Petkov
2016-08-30 8:35 ` joeyli
2016-08-30 11:54 ` Rafael J. Wysocki
2016-09-08 21:15 ` Pavel Machek
2016-09-09 7:36 ` Chen Yu
2016-09-09 7:33 ` Pavel Machek
2016-08-30 11:51 ` Rafael J. Wysocki
2016-08-29 13:41 ` Rafael J. Wysocki
2016-08-29 15:13 ` Pavel Machek
2016-08-30 12:04 ` Rafael J. Wysocki
2016-08-30 19:53 ` Pavel Machek
2016-08-30 21:50 ` Rafael J. Wysocki
2016-08-31 11:03 ` Pavel Machek
2016-08-31 0:27 ` Rafael J. Wysocki
2016-08-31 11:07 ` Pavel Machek
2016-08-31 11:43 ` Pavel Machek
2016-08-31 11:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C4A438.6090800@redhat.com \
--to=prarit@redhat.com \
--cc=bp@alien8.de \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).