From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756784AbcH2Xor (ORCPT ); Mon, 29 Aug 2016 19:44:47 -0400 Received: from www62.your-server.de ([213.133.104.62]:33068 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbcH2Xoq (ORCPT ); Mon, 29 Aug 2016 19:44:46 -0400 Message-ID: <57C4C8E2.6040903@iogearbox.net> Date: Tue, 30 Aug 2016 01:44:34 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexei Starovoitov , "David S . Miller" CC: Peter Zijlstra , Brendan Gregg , Arnaldo Carvalho de Melo , Wang Nan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH net-next 1/6] bpf: support 8-byte metafield access References: <1472265084-1767670-1-git-send-email-ast@fb.com> <1472265084-1767670-2-git-send-email-ast@fb.com> In-Reply-To: <1472265084-1767670-2-git-send-email-ast@fb.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2016 04:31 AM, Alexei Starovoitov wrote: > The verifier supported only 4-byte metafields in > struct __sk_buff and struct xdp_md. The metafields in upcoming > struct bpf_perf_event are 8-byte to match register width in struct pt_regs. > Teach verifier to recognize 8-byte metafield access. > The patch doesn't affect safety of sockets and xdp programs. > They check for 4-byte only ctx access before these conditions are hit. > > Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann