From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756769AbcHaBZH (ORCPT ); Tue, 30 Aug 2016 21:25:07 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60125 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbcHaBZD (ORCPT ); Tue, 30 Aug 2016 21:25:03 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-4e-57c631ecbb0f Content-transfer-encoding: 8BIT Message-id: <57C631EB.2080401@samsung.com> Date: Wed, 31 Aug 2016 10:24:59 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring Cc: k.kozlowski@samsung.com, kgene@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, jh80.chung@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, jonghwa3.lee@samsung.com, beomho.seo@samsung.com, jaewon02.kim@samsung.com, human.hwang@samsung.com, ideal.song@samsung.com, ingi2.kim@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, chanwoo@kernel.org Subject: Re: [PATCH v2 6/7] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board References: <1472046551-703-1-git-send-email-cw00.choi@samsung.com> <1472046551-703-7-git-send-email-cw00.choi@samsung.com> <20160830171146.GA22946@rob-hp-laptop> In-reply-to: <20160830171146.GA22946@rob-hp-laptop> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42JZI2JSqPvG8Fi4QcMNZYtb686xWpz+tI3d 4v2yHkaLiTeusFjMPwIUWzqjj9Vi19/7jBY7bn5hs5h0fwKLxY6GI6wWN361sVp0nn3CbPHi 3kUWi9cvDC36H79mtjh/fgO7xabH11gtLu+aw2Yx4/w+Jou1R+6yWyy9fpHJ4v+eHewWh9+0 s1rMmPySzeLlxxMsDpIea+atYfTYtKqTzWPzknqPvi2rGD0+b5ILYI3isklJzcksSy3St0vg yrjZ/Zy5YLNixeaO72wNjPOluxg5OSQETCRal25hg7DFJC7cWw9kc3EICaxglNg37Q9LFyMH WNHJ85kQ8aWMEvunrANr4BUQlPgx+R5YDbOAvMSRS9kgYWYBdYlJ8xYxg9hCAg8YJfZu0oQo 15JoPvAHLM4ioCqx5+cjdhCbDSi+/8UNsJH8AooSV388ZgQZKSoQIdF9ohIkLAIU/t02jRXk BGaBxywS1+8+ZAapERaIlfjzjwnitF+MEi275jGCNHAKGEus7bzOApKQEHjCIfFwyi92iMUC Et8mH4L6S1Zi0wFmiN8lJQ6uuMEygVF8FpLPZiF8NgvJZwsYmVcxiqYWJBcUJ6UXGeoVJ+YW l+al6yXn525iBCaO0/+e9e5gvH3A+hCjAAejEg9vxoyj4UKsiWXFlbmHGE2BjpjILCWanA9M T3kl8YbGZkYWpiamxkbmlmZK4ryKUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTBKrpwg 8XrhFWlRz4VTfFZe5fn/+7ni2q/5bzZeyuDQc6/5o7l7Vci1IPYtNr/0ZY4JuP8IXxr9WvaL RrllpfbfkqT5z357BS7SvXdGYffVvVseCa5QCT1ZpiRa+q7z0FTRJl6GBScupxT8/uneqPd6 r3KkeXfA+msuetNft8ffO5Ng/qouQC1diaU4I9FQi7moOBEANA+J7hcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIKsWRmVeSWpSXmKPExsVy+t9jAd03hsfCDTreSVncWneO1eL0p23s Fu+X9TBaTLxxhcVi/hGg2NIZfawWu/7eZ7TYcfMLm8Wk+xNYLHY0HGG1uPGrjdWi8+wTZosX 9y6yWLx+YWjR//g1s8X58xvYLTY9vsZqcXnXHDaLGef3MVmsPXKX3WLp9YtMFv/37GC3OPym ndVixuSXbBYvP55gcZD0WDNvDaPHplWdbB6bl9R79G1ZxejxeZNcAGtUA6NNRmpiSmqRQmpe cn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtB/SgpliTmlQKGAxOJiJX07 TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMm93PmQs2K1Zs7vjO1sA4X7qLkYNDQsBE4uT5zC5G TiBTTOLCvfVsXYxcHEICSxkl9k9ZxwaS4BUQlPgx+R4LSD2zgLzEkUvZIGFmAXWJSfMWMYPY QgIPGCX2btKEKNeSaD7wByzOIqAqsefnI3YQmw0ovv/FDbCR/AKKEld/PGYEGSkqECHRfaIS JCwCFP7dNo0V5ARmgccsEtfvPmQGqREWiJX4848J4rRfjBItu+YxgjRwChhLrO28zjKBUXAW kktnIVw6C8mlCxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIEJ6dnUjsYD+5yP8Qo wMGoxMP7gPFYuBBrYllxZe4hRgkOZiUR3l/6QCHelMTKqtSi/Pii0pzU4kOMpkC/TmSWEk3O BybOvJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1MPbt0CmJnLZt D3eZb8CtF5suTFUxLzGxPVwoYyLrZfnIpNW6bOpm8XflxfeSDbU4zmfeb1nu1zFDKMuv3+Yc 18rbZ9gNMj4bLUqJu1KSzl586mNcenVgYH+28vYLW99Ybjrxw/SxhYNGQWXe6qfqixP/Zftx tXB0BW79fTXjdfG2Ro8GxVPRSizFGYmGWsxFxYkAcM/TDWQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2016년 08월 31일 02:11, Rob Herring wrote: > On Wed, Aug 24, 2016 at 10:49:10PM +0900, Chanwoo Choi wrote: >> This patch adds the Device Tree source for Exynos5433-based Samsung TM2 board. >> This board fully support the all things for mobile target. >> >> This patch supports the following devices: >> 1. basic SoC >> - Initial booting for Samsung Exynos5433 SoC >> - DRAM LPDDR3 (3GB) >> - eMMC (32GB) >> - ARM architecture timer >> >> 2. power management devices >> - Sasmung S2MPS13 PMIC for the power supply >> - CPUFREQ for big.LITTLE cores >> - TMU for big.LITTLE cores and GPU >> - ADC with thermistor to measure the temperature of AP/Battery/Charger >> - Maxim MAX77843 Interface PMIC (MUIC/Haptic/Regulator) >> >> 3. sound devices >> - I2S for sound bus >> - LPASS for sound power control >> - Wolfson WM5110 for sound codec >> - Maxim MAX98504 for speaker amplifier >> - TM2 ASoC Machine device driver node >> >> 3. display devices >> - DECON, DSI and MIC for the panel output >> >> 4. usb devices >> - USB 3.0 DRD (Dual Role Device) >> - USB 3.0 Host controller >> >> 5. storage devices >> - MSHC (Mobile Storae Host Controller) for eMMC device >> >> 6. misc devices >> - gpio-keys (power, volume up/down, home key) >> - PWM (Pulse Width Modulation Timer) >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Seung-Woo Kim >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Inki Dae >> Signed-off-by: Jonghwa Lee >> Signed-off-by: Beomho Seo >> Signed-off-by: Jaewon Kim >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Inha Song >> Signed-off-by: Ingi kim >> Signed-off-by: Krzysztof Kozlowski >> Signed-off-by: Marek Szyprowski >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Sylwester Nawrocki >> --- >> .../bindings/arm/samsung/samsung-boards.txt | 1 + >> arch/arm64/boot/dts/exynos/Makefile | 5 +- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 985 +++++++++++++++++++++ >> 3 files changed, 990 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> >> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> index 0ea7f14ef294..c704b4bf6137 100644 >> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> @@ -15,6 +15,7 @@ Required root node properties: >> - "samsung,xyref5260" - for Exynos5260-based Samsung board. >> - "samsung,smdk5410" - for Exynos5410-based Samsung SMDK5410 eval board. >> - "samsung,smdk5420" - for Exynos5420-based Samsung SMDK5420 eval board. >> + - "samsung,tm2" - for Exynos5333-based Samsung TM2 board. > > This does not match... It is my mistake. Exynos5433 is correct. I'll fix it. > >> + compatible = "samsung,exynos5433-tm2", "samsung,exynos5433"; > > Is it 5433 or 5333? > >> + >> + aliases { >> + pinctrl0 = &pinctrl_alive; >> + pinctrl1 = &pinctrl_aud; >> + pinctrl2 = &pinctrl_cpif; >> + pinctrl3 = &pinctrl_ese; >> + pinctrl4 = &pinctrl_finger; >> + pinctrl5 = &pinctrl_fsys; >> + pinctrl6 = &pinctrl_imem; >> + pinctrl7 = &pinctrl_nfc; >> + pinctrl8 = &pinctrl_peric; >> + pinctrl9 = &pinctrl_touch; > > Drop all these. As I said on previous reply on v1 patches, The alias of both pinctrl and spi are used on the pinctrl/spi driver. If I drop the alias of both pinctrl and spi, the error happened. > >> + serial0 = &serial_0; >> + serial1 = &serial_1; >> + serial2 = &serial_2; >> + serial3 = &serial_3; > >> + spi0 = &spi_0; >> + spi1 = &spi_1; >> + spi2 = &spi_2; >> + spi3 = &spi_3; >> + spi4 = &spi_4; > > And these. ditto. -- Best Regards, Chanwoo Choi