public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: rockchip: add 2016M to big cpu clk rate table
@ 2016-08-31 23:06 Shunqian Zheng
  2016-09-01  6:08 ` Xing Zheng
  2016-09-01 11:35 ` Heiko Stübner
  0 siblings, 2 replies; 3+ messages in thread
From: Shunqian Zheng @ 2016-08-31 23:06 UTC (permalink / raw)
  To: zhengxing, heiko, sboyd, mturquette, dianders
  Cc: linux-clk, linux-rockchip, zhangqing, linux-kernel,
	Shunqian Zheng

We would prefer the 2016M as 2.0G than 1992M which seems odd, adding
it to big cpu clk rate table then we can set 2016M in dts.

Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
---
 drivers/clk/rockchip/clk-rk3399.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
index ede6c47..a6a15c6 100644
--- a/drivers/clk/rockchip/clk-rk3399.c
+++ b/drivers/clk/rockchip/clk-rk3399.c
@@ -375,6 +375,7 @@ static struct rockchip_cpuclk_rate_table rk3399_cpuclkb_rates[] __initdata = {
 	RK3399_CPUCLKB_RATE(2184000000, 1, 11, 11),
 	RK3399_CPUCLKB_RATE(2088000000, 1, 10, 10),
 	RK3399_CPUCLKB_RATE(2040000000, 1, 10, 10),
+	RK3399_CPUCLKB_RATE(2016000000, 1, 9, 9),
 	RK3399_CPUCLKB_RATE(1992000000, 1, 9, 9),
 	RK3399_CPUCLKB_RATE(1896000000, 1, 9, 9),
 	RK3399_CPUCLKB_RATE(1800000000, 1, 8, 8),
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: rockchip: add 2016M to big cpu clk rate table
  2016-08-31 23:06 [PATCH] clk: rockchip: add 2016M to big cpu clk rate table Shunqian Zheng
@ 2016-09-01  6:08 ` Xing Zheng
  2016-09-01 11:35 ` Heiko Stübner
  1 sibling, 0 replies; 3+ messages in thread
From: Xing Zheng @ 2016-09-01  6:08 UTC (permalink / raw)
  To: Shunqian Zheng, heiko, sboyd, mturquette, dianders
  Cc: linux-clk, linux-rockchip, zhangqing, linux-kernel

Hi Shunqian,

On 2016年09月01日 07:06, Shunqian Zheng wrote:
> We would prefer the 2016M as 2.0G than 1992M which seems odd, adding
> it to big cpu clk rate table then we can set 2016M in dts.
>
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rk3399.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index ede6c47..a6a15c6 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -375,6 +375,7 @@ static struct rockchip_cpuclk_rate_table rk3399_cpuclkb_rates[] __initdata = {
>   	RK3399_CPUCLKB_RATE(2184000000, 1, 11, 11),
>   	RK3399_CPUCLKB_RATE(2088000000, 1, 10, 10),
>   	RK3399_CPUCLKB_RATE(2040000000, 1, 10, 10),
> +	RK3399_CPUCLKB_RATE(2016000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1992000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1896000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1800000000, 1, 8, 8),
It looks good to me.

Reviewed-by: Xing Zheng <zhengxing@rock-chips.com>

Thanks.

-- 
- Xing Zheng

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: rockchip: add 2016M to big cpu clk rate table
  2016-08-31 23:06 [PATCH] clk: rockchip: add 2016M to big cpu clk rate table Shunqian Zheng
  2016-09-01  6:08 ` Xing Zheng
@ 2016-09-01 11:35 ` Heiko Stübner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2016-09-01 11:35 UTC (permalink / raw)
  To: Shunqian Zheng
  Cc: zhengxing, sboyd, mturquette, dianders, linux-clk, linux-rockchip,
	zhangqing, linux-kernel

Am Donnerstag, 1. September 2016, 07:06:22 schrieb Shunqian Zheng:
> We would prefer the 2016M as 2.0G than 1992M which seems odd, adding
> it to big cpu clk rate table then we can set 2016M in dts.
> 
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>

applied to my clk-branch for 4.9 with Xing's review-tag


Thanks
Heiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-01 11:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-31 23:06 [PATCH] clk: rockchip: add 2016M to big cpu clk rate table Shunqian Zheng
2016-09-01  6:08 ` Xing Zheng
2016-09-01 11:35 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox