From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbcIAGIo (ORCPT ); Thu, 1 Sep 2016 02:08:44 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:55819 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcIAGIn (ORCPT ); Thu, 1 Sep 2016 02:08:43 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <5e3baa46fe23b15bdad1c22d50918f14> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] clk: rockchip: add 2016M to big cpu clk rate table To: Shunqian Zheng , heiko@sntech.de, sboyd@codeaurora.org, mturquette@baylibre.com, dianders@chromium.org References: <1472684782-17940-1-git-send-email-zhengsq@rock-chips.com> Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, zhangqing@rock-chips.com, linux-kernel@vger.kernel.org From: Xing Zheng Message-ID: <57C7C5D2.7000404@rock-chips.com> Date: Thu, 1 Sep 2016 14:08:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1472684782-17940-1-git-send-email-zhengsq@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shunqian, On 2016年09月01日 07:06, Shunqian Zheng wrote: > We would prefer the 2016M as 2.0G than 1992M which seems odd, adding > it to big cpu clk rate table then we can set 2016M in dts. > > Signed-off-by: Shunqian Zheng > --- > drivers/clk/rockchip/clk-rk3399.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c > index ede6c47..a6a15c6 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -375,6 +375,7 @@ static struct rockchip_cpuclk_rate_table rk3399_cpuclkb_rates[] __initdata = { > RK3399_CPUCLKB_RATE(2184000000, 1, 11, 11), > RK3399_CPUCLKB_RATE(2088000000, 1, 10, 10), > RK3399_CPUCLKB_RATE(2040000000, 1, 10, 10), > + RK3399_CPUCLKB_RATE(2016000000, 1, 9, 9), > RK3399_CPUCLKB_RATE(1992000000, 1, 9, 9), > RK3399_CPUCLKB_RATE(1896000000, 1, 9, 9), > RK3399_CPUCLKB_RATE(1800000000, 1, 8, 8), It looks good to me. Reviewed-by: Xing Zheng Thanks. -- - Xing Zheng