From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbcIBJtg (ORCPT ); Fri, 2 Sep 2016 05:49:36 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44462 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcIBJtd (ORCPT ); Fri, 2 Sep 2016 05:49:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 9209561F17 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH 4/4 v2] drm/bridge: adv7511: Initialize audio packet on adv7533 To: John Stultz , lkml References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <1472514096-10915-5-git-send-email-john.stultz@linaro.org> Cc: Andy Green , David Airlie , Laurent Pinchart , Wolfram Sang , Srinivas Kandagatla , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Boris Brezillon , Andy Green , Dave Long , Guodong Xu , Zhangfei Gao , Mark Brown , Lars-Peter Clausen , Jose Abreu , dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: <57C94B1D.8040509@codeaurora.org> Date: Fri, 2 Sep 2016 15:19:17 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1472514096-10915-5-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/30/2016 5:11 AM, John Stultz wrote: > From: Andy Green > > Set the initial audio packet settings to allow the audio > driver to work. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Laurent Pinchart > Cc: Wolfram Sang > Cc: Srinivas Kandagatla > Cc: "Ville Syrjälä" > Cc: Boris Brezillon > Cc: Andy Green > Cc: Dave Long > Cc: Guodong Xu > Cc: Zhangfei Gao > Cc: Mark Brown > Cc: Lars-Peter Clausen > Cc: Jose Abreu > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Andy Green > [jstultz: Forward ported to mainline, changed to use register > names rather then hex values, and removed config values set by > audio driver.] > Signed-off-by: John Stultz > --- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c > index 6798ecf..cced7c9 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c > @@ -104,6 +104,28 @@ void adv7533_dsi_power_on(struct adv7511 *adv) > /* disable test mode */ > regmap_write(adv->regmap_cec, 0x55, 0x00); > > + /* hide Audio infoframe updates */ > + regmap_update_bits(adv->regmap, ADV7511_REG_INFOFRAME_UPDATE, > + BIT(5), BIT(5)); > + /* enable N/CTS, enable Audio sample packets */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(5), BIT(5)); > + /* enable N/CTS */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(6), BIT(6)); > + /* not copyrighted */ > + regmap_update_bits(adv->regmap, ADV7511_REG_AUDIO_CFG1, > + BIT(5), BIT(5)); > + /* enable audio infoframes */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(3), BIT(3)); > + /* AV mute disable */ > + regmap_update_bits(adv->regmap, ADV7511_REG_GC(0), > + BIT(7) | BIT(6), BIT(7)); > + /* use Audio infoframe updated info */ > + regmap_update_bits(adv->regmap, ADV7511_REG_GC(1), > + BIT(5), 0); > + Wouldn't these writes be needed by ADV751x chips too? These seem to belong to the main ADV75xx regmap. These should probably be a separate func in adv7511_audio.c or adv7511_drv.c, and it should be called in adv7511_power_on, so that ADV751x chips can utilize this too. Thanks, Archit > regmap_register_patch(adv->regmap_cec, adv7533_cec_fixed_registers, > ARRAY_SIZE(adv7533_cec_fixed_registers)); > } > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project