From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbcIBMPq (ORCPT ); Fri, 2 Sep 2016 08:15:46 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:36352 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbcIBMPo (ORCPT ); Fri, 2 Sep 2016 08:15:44 -0400 Subject: Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static To: Arnd Bergmann , Baoyou Xie References: <1472634319-11886-1-git-send-email-baoyou.xie@linaro.org> <7060924.RuInUXIHDe@wuerfel> CC: , , , , , From: Kishon Vijay Abraham I Message-ID: <57C96D64.9050600@ti.com> Date: Fri, 2 Sep 2016 17:45:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <7060924.RuInUXIHDe@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday 31 August 2016 03:31 PM, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote: >> We get 1 warning when building kernel with W=1: >> drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is >> declared and don't need a declaration, but can be made static. >> So this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie >> > > Acked-by: Arnd Bergmann > > Same comment as for the other patch, it's better to use "phy: tegra: ..." > in the subject for clarity. Fixed it myself and merged this and the other patch. Thanks Kishon