From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbcIBMRO (ORCPT ); Fri, 2 Sep 2016 08:17:14 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:38321 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcIBMRL (ORCPT ); Fri, 2 Sep 2016 08:17:11 -0400 Subject: Re: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops To: Axel Lin References: <1472565240-31053-1-git-send-email-axel.lin@ingics.com> <1472565240-31053-2-git-send-email-axel.lin@ingics.com> CC: Pramod Kumar , Andrew Lunn , Jon Mason , From: Kishon Vijay Abraham I Message-ID: <57C96DB9.6080904@ti.com> Date: Fri, 2 Sep 2016 17:46:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1472565240-31053-2-git-send-email-axel.lin@ingics.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 30 August 2016 07:24 PM, Axel Lin wrote: > Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. > While at it, also makes ns2_pci_phy_ops const as it's never get modified. > > Signed-off-by: Axel Lin > Reviewed-and-tested-by: Jon Mason merged, thanks -Kishon > --- > This was sent on http://www.spinics.net/lists/netdev/msg383514.html > Resent on https://lkml.org/lkml/2016/8/12/659 > drivers/phy/phy-bcm-ns2-pcie.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-bcm-ns2-pcie.c b/drivers/phy/phy-bcm-ns2-pcie.c > index ee61772..4c7d11d 100644 > --- a/drivers/phy/phy-bcm-ns2-pcie.c > +++ b/drivers/phy/phy-bcm-ns2-pcie.c > @@ -47,8 +47,9 @@ err: > return rc; > } > > -static struct phy_ops ns2_pci_phy_ops = { > +static const struct phy_ops ns2_pci_phy_ops = { > .init = ns2_pci_phy_init, > + .owner = THIS_MODULE, > }; > > static int ns2_pci_phy_probe(struct mdio_device *mdiodev) >