From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932725AbcIBPgx (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 11:36:53 -0400
Received: from smtpoutz29.laposte.net ([194.117.213.104]:56597 "EHLO
        smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S932309AbcIBPgt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 11:36:49 -0400
Subject: Re: [PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip
To: Thomas Gleixner <tglx@linutronix.de>
References: <579F5C5A.2070507@laposte.net>
 <alpine.DEB.2.20.1609021706140.5647@nanos>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        Jason Cooper <jason@lakedaemon.net>,
        LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
From: Sebastian Frias <sf84@laposte.net>
Message-ID: <57C99C8D.7070503@laposte.net>
Date: Fri, 2 Sep 2016 17:36:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1609021706140.5647@nanos>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-VR-SrcIP: 78.31.43.6
X-VR-FullState: 0
X-VR-Score: -100
X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeeluddrheefgdeltdculddtuddrfeeltddrtddtmdcutefuodet
X-VR-Cause-2: ggdotefrodftvfcurfhrohhfihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecu
X-VR-Cause-3: secvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjegr
X-VR-Cause-4: tddtfeehnecuhfhrohhmpefuvggsrghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgv
X-VR-Cause-5: rdhnvghtqeenucffohhmrghinheplhhkmhhlrdhorhhgnecukfhppeejkedrfedurdegfedrieenucfr
X-VR-Cause-6: rghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopegludejvddrvdejrddtrddvudegngdpihhn
X-VR-Cause-7: vghtpeejkedrfedurdegfedriedpmhgrihhlfhhrohhmpehsfhekgeeslhgrphhoshhtvgdrnhgvthdp
X-VR-Cause-8: rhgtphhtthhopehtghhlgieslhhinhhuthhrohhnihigrdguvg
X-VR-AvState: No
X-VR-State: 0
X-VR-State: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thomas,

On 09/02/2016 05:12 PM, Thomas Gleixner wrote:
> On Mon, 1 Aug 2016, Sebastian Frias wrote:
>> NOTE: While the proposed unmap() function attempts to undo as much things
>> as done by the map() function, I did not find a way to undo the following:
>>
>> a) irq_gc_init_mask_cache(gc, dgc->gc_flags)
> 
> You can't undo that. Because that represents the mask cache of the irq chip
> and that is required to be consistent over the life time of the irq
> chip.
> 
> Unmapping does not make the generic chip and the underlying irqchip go
> away.
> 
>> b) irq_set_lockdep_class(virq, &irq_nested_lock_class)
> 
> No point in undoing that. The irq descriptor is released on unmap.
> 
>> c) irq_modify_status(virq, dgc->irq_flags_to_clear, dgc->irq_flags_to_set)
> 
> See b)
> 

Thanks for your time, I gather from this that the patch is ok then?

I submitted a few more patches, one of them a follow up of this one, and some
more, here are pointers to them just in case:
   https://lkml.org/lkml/2016/8/1/302
   https://lkml.org/lkml/2016/8/2/118
   https://lkml.org/lkml/2016/8/19/598

Best regards,

Sebastian