[PATCH] clocksource: pxa_timer: add missing header dependencies

[PATCH] clocksource: pxa_timer: add missing header dependencies

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/clocksource/pxa_timer.c:221:13: warning: no previous prototype for 'pxa_timer_nodt_init' [-Wmissing-prototypes]

In fact, this function is declared in include/clocksource/pxa.h,
although it's not referenced anywhere now, it can be referenced 
by someone out of nowhere in future, so this patch adds missing
header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/clocksource/pxa_timer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clocksource/pxa_timer.c b/drivers/clocksource/pxa_timer.c
index 937e10b..3e1cb51 100644
--- a/drivers/clocksource/pxa_timer.c
+++ b/drivers/clocksource/pxa_timer.c
@@ -21,6 +21,8 @@
 #include <linux/of_irq.h>
 #include <linux/sched_clock.h>
 
+#include <clocksource/pxa.h>
+
 #include <asm/div64.h>
 
 #define OSMR0		0x00	/* OS Timer 0 Match Register */
-- 
2.7.4

Re: [PATCH] clocksource: pxa_timer: add missing header dependencies

[Daniel Lezcano]

On 09/03/2016 05:18 AM, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clocksource/pxa_timer.c:221:13: warning: no previous prototype for 'pxa_timer_nodt_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in include/clocksource/pxa.h,
> although it's not referenced anywhere now, it can be referenced 
> by someone out of nowhere in future, so this patch adds missing
> header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---

Already applied [1].

Thanks.

[1]
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=aa8c0f1ad7e862147f4efb32bbb71ff66eb38caa


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog