Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

Chen Gang
2016-08-29T22:25:10Z

On 8/29/16 21:03, Arnd Bergmann wrote:
> On Sunday 28 August 2016, chengang@emindsoft.com.cn wrote:
>> From: Chen Gang <chengang@emindsoft.com.cn>
>>
>> Also use the same changing to asm-generic, and also use bool variable
>> instead of int variable for mips, mn10300, parisc and tile related
>> functions, and also avoid checkpatch.pl to report ERROR.
>>
>> Originally, except powerpc and xtensa, all another architectures intend
>> to return 0 or 1. After this patch, also let powerpc and xtensa return 0
>> or 1.
>>
>> The patch passes cross building for mips and parisc with default config.
>> All related contents are found by "grep test_bit, grep test_and" under
>> arch sub-directory.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> This seems like a good idea overall, and I'm fine with the asm-generic
> contents. If there is consensus on changing this, we probably also want
> to do some other steps:
>
> - Change the Documentation/atomic_ops.txt file accordingly
> - split up the series per architecture (I don't think there are any
> interdependencies)
> - For the architectures on which the definition changes (at least
> x86 and ARM), do some more sanity checks and see if there are
> noticeable changes in object code, and if so whether it looks
> better or worse (I'm guessing it will be better if anything)
> - See which architectures can still get converted to using the
> asm-generic headers instead of providing their own, I think at
> least for the nonatomic ones, there are a couple.
>

Thank you for your ideas, suggestions, and completions.

And I guess, at least for arc, I or another related members will try to
check the object code.

Thanks.
--
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.