From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Kees Cook <keescook@chromium.org>,
Dave Hansen <dave.hansen@intel.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V3] mm: Add sysfs interface to dump each node's zonelist information
Date: Wed, 07 Sep 2016 09:30:08 +0530 [thread overview]
Message-ID: <57CF90C8.6050409@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAGXu5jK_sKa2dcVrwhXdp=ZA=ACEY6vmd-LDoy8KmMtCn_aDzw@mail.gmail.com>
On 09/07/2016 08:38 AM, Kees Cook wrote:
> On Tue, Sep 6, 2016 at 1:36 PM, Dave Hansen <dave.hansen@intel.com> wrote:
>> On 09/06/2016 01:31 AM, Anshuman Khandual wrote:
>>> [NODE (0)]
>>> ZONELIST_FALLBACK
>>> (0) (node 0) (zone DMA c00000000140c000)
>>> (1) (node 1) (zone DMA c000000100000000)
>>> (2) (node 2) (zone DMA c000000200000000)
>>> (3) (node 3) (zone DMA c000000300000000)
>>> ZONELIST_NOFALLBACK
>>> (0) (node 0) (zone DMA c00000000140c000)
>>
>> Don't we have some prohibition on dumping out kernel addresses like this
>> so that attackers can't trivially defeat kernel layout randomization?
>
> Anything printing memory addresses should be using %pK (not %lx as done here).
Learned about the significance of %pK coupled with kptr_restrict
interface. Will change this. Thanks for pointing out.
next prev parent reply other threads:[~2016-09-07 4:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 5:34 [PATCH V2 1/2] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual
2016-09-06 5:34 ` [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information Anshuman Khandual
2016-09-06 6:11 ` kbuild test robot
2016-09-06 6:49 ` Anshuman Khandual
2016-09-06 8:31 ` [PATCH V3] " Anshuman Khandual
2016-09-06 9:05 ` kbuild test robot
2016-09-07 12:32 ` Anshuman Khandual
2016-09-06 20:36 ` Dave Hansen
2016-09-07 3:08 ` Kees Cook
2016-09-07 4:00 ` Anshuman Khandual [this message]
2016-09-08 2:46 ` [PATCH V4] " Anshuman Khandual
2016-09-08 7:44 ` kbuild test robot
2016-09-08 20:24 ` Dave Hansen
2016-09-12 5:27 ` Anshuman Khandual
2016-09-12 18:13 ` David Rientjes
2016-09-17 4:26 ` Anshuman Khandual
2016-09-20 0:54 ` David Rientjes
2016-10-13 14:38 ` Anshuman Khandual
2016-09-09 13:36 ` Michal Hocko
2016-09-12 5:24 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CF90C8.6050409@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).