From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbcIGFMS (ORCPT ); Wed, 7 Sep 2016 01:12:18 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34008 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcIGFMQ (ORCPT ); Wed, 7 Sep 2016 01:12:16 -0400 X-IBM-Helo: d28dlp01.in.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 07 Sep 2016 10:42:01 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Williams , linux-nvdimm@ml01.01.org CC: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm: cleanup pfn_t usage in track_pfn_insert() References: <147318056046.30325.5100892122988191500.stgit@dwillia2-desk3.amr.corp.intel.com> <147318058712.30325.12749411762275637099.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <147318058712.30325.12749411762275637099.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090705-0052-0000-0000-000002EC3F72 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090705-0053-0000-0000-00000E899F06 Message-Id: <57CFA1A1.7060704@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-07_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609070078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 10:19 PM, Dan Williams wrote: > Now that track_pfn_insert() is no longer used in the DAX path, it no > longer needs to comprehend pfn_t values. > > Signed-off-by: Dan Williams > --- > arch/x86/mm/pat.c | 4 ++-- > include/asm-generic/pgtable.h | 4 ++-- > mm/memory.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) A small nit. Should not the arch/x86/mm/pat.c changes be separated out into a different patch ? Kind of faced little bit problem separating out generic core mm changes to that of arch specific mm changes when going through the commits in retrospect.