Re: [PATCH 5/5] mm: cleanup pfn_t usage in track_pfn_insert()

Dan Williams
2016-09-07T15:47:15Z

On Tue, Sep 6, 2016 at 10:12 PM, Anshuman Khandual
<khandual@linux.vnet.ibm.com> wrote:
> On 09/06/2016 10:19 PM, Dan Williams wrote:
>> Now that track_pfn_insert() is no longer used in the DAX path, it no
>> longer needs to comprehend pfn_t values.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> ---
>> arch/x86/mm/pat.c | 4 ++--
>> include/asm-generic/pgtable.h | 4 ++--
>> mm/memory.c | 2 +-
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> A small nit. Should not the arch/x86/mm/pat.c changes be separated out
> into a different patch ? Kind of faced little bit problem separating out
> generic core mm changes to that of arch specific mm changes when going
> through the commits in retrospect.

I'm going to drop this change. Leaving it as is does no harm, and
users of pfn_t are likely to grow over time.