From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756809AbcIGPiF (ORCPT ); Wed, 7 Sep 2016 11:38:05 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49935 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751959AbcIGPiD (ORCPT ); Wed, 7 Sep 2016 11:38:03 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com Subject: Re: [PATCH] perf/powerpc: Fix build-test failure To: acme@kernel.org References: <1472630591-5089-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Ravi Bangoria From: Ravi Bangoria Date: Wed, 7 Sep 2016 21:07:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1472630591-5089-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090715-0020-0000-0000-000009B9D2C8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005722; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000185; SDB=6.00754960; UDB=6.00357362; IPR=6.00527841; BA=6.00004701; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012613; XFM=3.00000011; UTC=2016-09-07 15:38:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090715-0021-0000-0000-000055433B1D Message-Id: <57D03452.6060402@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609070238 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, Can you please pick up this. -Ravi On Wednesday 31 August 2016 01:33 PM, Ravi Bangoria wrote: > 'make -C tools/perf build-test' is failing with below log for poewrpc. > > In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0, > from util/cpumap.h:8, > from util/env.c:1: > /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56: > fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory > compilation terminated. > > I bisected it and found it's failing from commit ad430729ae00 ("Remove: > kernel unistd*h files from perf's MANIFEST, not used"). > > Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included > only for powerpc in tools/perf/perf-sys.h. > > By looking closly at commit history, I found little weird thing: > > Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build > error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h' > > Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI > disintegration applied") removes all arch specific 'uapi/asm/unistd.h' > for all archs and adds generic . > > Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again > includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this > happened as this change is not part of commit also. > > Signed-off-by: Ravi Bangoria > --- > tools/perf/perf-sys.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h > index 7ed72a4..e4b717e 100644 > --- a/tools/perf/perf-sys.h > +++ b/tools/perf/perf-sys.h > @@ -20,7 +20,6 @@ > #endif > > #ifdef __powerpc__ > -#include "../../arch/powerpc/include/uapi/asm/unistd.h" > #define CPUINFO_PROC {"cpu"} > #endif >