From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966283AbcIHJvp (ORCPT ); Thu, 8 Sep 2016 05:51:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:12792 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965868AbcIHJvm (ORCPT ); Thu, 8 Sep 2016 05:51:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,300,1470726000"; d="scan'208";a="6345498" Subject: Re: [PATCH 1/1] usb: dwc3: fix Clear Stall EP command failure To: Felipe Balbi References: <1473324139-9965-1-git-send-email-baolu.lu@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Lu Baolu Message-ID: <57D134AD.3020506@linux.intel.com> Date: Thu, 8 Sep 2016 17:51:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1473324139-9965-1-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, On 09/08/2016 04:41 PM, Lu Baolu wrote: > Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear > Stall EP command") sets ClearPendIN bit for all IN endpoints in > v2.60a+ cores no matter which speed mode they're in. This causes > Clear Stall EP command failing on some Intel devices. > > In page 539 of 2.60a specification, it says: > > "When issuing Clear Stall command for IN endpoints in SuperSpeed > mode, the software must set the "ClearPendIN" bit to '1' to > clear any pending IN transcations, so that the device does not > expect any ACK TP from the host for the data sent earlier." > > It's obviously that we only need to apply this rule to those IN > endpoints in SuperSpeed mode. > > Fixes: 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command") > Cc: stable@vger.kernel.org # 4.7+ > Signed-off-by: Lu Baolu > --- > drivers/usb/dwc3/gadget.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 7a8d3d8..f1858d6 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -348,7 +348,8 @@ static int dwc3_send_clear_stall_ep_cmd(struct dwc3_ep *dep) > * IN transfers due to a mishandled error condition. Synopsys > * STAR 9000614252. > */ > - if (dep->direction && (dwc->revision >= DWC3_REVISION_260A)) > + if (dep->direction && (dwc->revision >= DWC3_REVISION_260A) && > + (dwc->maximum_speed >= USB_SPEED_SUPER)) > cmd |= DWC3_DEPCMD_CLEARPENDIN; > > memset(¶ms, 0, sizeof(params)); Oh, my bad. I'm sending you a patch which hasn't been verified on the real hardware yet. My mind goes blank after a whole day's work. Poor me. :-( I will send you a refreshed one tomorrow. Really sorry about it. Best regards, Lu Baolu