From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934695AbcIHL1W (ORCPT ); Thu, 8 Sep 2016 07:27:22 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38347 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759428AbcIHL1U (ORCPT ); Thu, 8 Sep 2016 07:27:20 -0400 Subject: Re: [PATCH] scripts: add ksymbolize.py To: Tejun Heo , Alexander Potapenko References: <1472056655-30791-1-git-send-email-glider@google.com> <20160824164042.GA2950@htj.duckdns.org> Cc: dvyukov@google.com, kcc@google.com, aryabinin@virtuozzo.com, adech.fo@gmail.com, akpm@linux-foundation.org, alexander.levin@verizon.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org From: Nikolay Borisov Message-ID: <57D14B14.2060008@gmail.com> Date: Thu, 8 Sep 2016 14:27:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160824164042.GA2950@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 07:40 PM, Tejun Heo wrote: > Hello, Alexander. > > On Wed, Aug 24, 2016 at 06:37:35PM +0200, Alexander Potapenko wrote: >> Commit the script that symbolizes BUG messages and KASAN error reports >> by adding file:line information to each stack frame. >> The script is a copy of >> https://github.com/google/sanitizers/blob/master/address-sanitizer/tools/kasan_symbolize.py >> , originally written by Andrey Konovalov. > > I really like the idea of having the script in the tree but can you > please be more detailed in the patch description (and possibly in the > help message of the tool)? e.g. describe what it can do and show some > examples. It's difficult to tell what the script is about from this > posting. I've tried to use the script but had to read the code to understand how exactly to run it. So I also second that a more verbose help is needed in the script. > > Thanks. >