From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966214AbcIHRNT (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 13:13:19 -0400
Received: from foss.arm.com ([217.140.101.70]:54510 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965842AbcIHRNS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 13:13:18 -0400
Subject: Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed
 over DT
To: Linus Walleij <linus.walleij@linaro.org>
References: <1473235931-19079-1-git-send-email-marc.zyngier@arm.com>
 <CACRpkdbXkbNq5JnM83doZMt5H_JSd-1fQ_kbv_k3HAe2QM71yA@mail.gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <57D19C2C.2050906@arm.com>
Date: Thu, 8 Sep 2016 18:13:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <CACRpkdbXkbNq5JnM83doZMt5H_JSd-1fQ_kbv_k3HAe2QM71yA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/09/16 23:18, Linus Walleij wrote:
> On Wed, Sep 7, 2016 at 10:12 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
>> Using a default trigger is a bad idea if using DT to configure
>> interrupts, as the device's interrupt specifier will always contain
>> the trigger configuration.
>>
>> Let's warn about that particular situation, and revert to not
>> having a default. Hopefully, the couple of drivers still using
>> this feature will quickly be fixed.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> Send the tested patch this time around...
> 
> I got it the first time, don't worry :D

Errrr, the first one didn't even compile (I'm such a moron sometimes).
Please apply this one instead, which has actually been compile-tested.

Sorry for the noise.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...