From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbcILBDH (ORCPT ); Sun, 11 Sep 2016 21:03:07 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:35670 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbcILBDF (ORCPT ); Sun, 11 Sep 2016 21:03:05 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-33-57d5fec72746 Content-transfer-encoding: 8BIT Message-id: <57D5FEC7.5020509@samsung.com> Date: Mon, 12 Sep 2016 10:03:03 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Chris Zhong , myungjoo.ham@samsung.com, linux@roeck-us.net Cc: linux-kernel@vger.kernel.org, cpgs@samsung.com, groeck@chromium.org Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property References: <1473467630-29675-1-git-send-email-zyw@rock-chips.com> In-reply-to: <1473467630-29675-1-git-send-email-zyw@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWyRsSkUPf4v6vhBq8u6lu8PKRpcerVMmaL y7vmsFk8WXiGyeJ24wo2i/kPdjA7sHnMbrjI4vF31n4Wj53fG9g9+rasYvT4vEkugDWKyyYl NSezLLVI3y6BK2Pm5F9sBWt4K/rPHGFtYHzM1cXIySEhYCLxYcU2FghbTOLCvfVsXYxcHEIC Kxglzp+4yAZT1DxrKjNEYimjRHNTKxNIgldAUOLH5HtA3RwczALyEkcuZYOEmQXUJSbNWwRV /4BRYsmqCSwQ9VoSWy61MoPYLAKqEmf2TWcHsdmA4vtf3ABbxi+gKHH1x2NGkJmiAhES3Scq QcIiAiESS39dZYZY5S5xcZI5SFhYwEVizptzrBCrZjBKzH6xgxUkwSngLPF3w3SwhITALXaJ r+3NrBB7BSS+TT4EdrOEgKzEpgPMED9KShxccYNlAqP4LCSfzUL4bBaSzxYwMq9iFE0tSC4o TkovMtQrTswtLs1L10vOz93ECIy/0/+e9e5gvH3A+hCjAAejEg+vxbWr4UKsiWXFlbmHGE2B jpjILCWanA+M8rySeENjMyMLUxNTYyNzSzMlcV5FqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZ ODilGhgd7vzp2KZVJ3+sJvTKopZ0vwvLNT837sqNWLCE9WGUlsXNLy+m3L7yQ8ViDfs8IZd1 WsaXbd68V+pbkNbbtTrsmdMPBZkDlbl3amoc9sksKc1YqbJCrfuKwhy5lr/FKbvcHJwO9iy7 c67QJUm1+FrBldfhe73940tluNs+eCrfV86ZyLhH+YASS3FGoqEWc1FxIgBMDQ5UugIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t9jAd3j/66GG7St1rJ4eUjT4tSrZcwW l3fNYbN4svAMk8XtxhVsFvMf7GB2YPOY3XCRxePvrP0sHju/N7B79G1ZxejxeZNcAGtUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMmZN/sRWs4a3oP3OEtYHxMVcXIyeH hICJRPOsqcwQtpjEhXvr2boYuTiEBJYySjQ3tTKBJHgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZ QF1i0rxFzBD1DxgllqyawAJRryWx5VIr2FAWAVWJM/ums4PYbEDx/S9usIHY/AKKEld/PGYE mSkqECHRfaISJCwiECKx9NdVZohV7hIXJ5mDhIUFXCTmvDnHCrFqBqPE7Bc7WEESnALOEn83 TGedwCg4C8mlsxAunYXk0gWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgmP8mdQO xoO73A8xCnAwKvHwOky6Gi7EmlhWXJl7iFGCg1lJhFf3L1CINyWxsiq1KD++qDQntfgQoynQ qxOZpUST84HpJ68k3tDYxMzI0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxSDYyu gflXwg6slW003prxy6pOoVn53O6tBbJ3jFmqaorTWefcy4/lePAjxu/4ix12k3S5PP4yyrvP mNW9T9gzoEPFuvfZdNUUrr2l34rOOPTeivngXrC8qtxbducchy9Myey2xZeDitmmnv6ouf/P vklHNX7F/bqzr9VfUiEjdb3ZGc80pQPvliqxFGckGmoxFxUnAgCVgw2UBwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 2016년 09월 10일 09:33, Chris Zhong wrote: > EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd > interrupt, this property can be used. What is meaning of HPD? So, you need to add the description and reference for HPD in commit message. For example, When adding EXTCON_PROP_USB_SS property[1], the commit message included the reference for USB SuperSpeed. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 > > Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed You have to remove the 'Change-Id'. > Signed-off-by: Chris Zhong > --- > include/linux/extcon.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index 9147c42..4411893 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -131,9 +131,21 @@ > #define EXTCON_PROP_JACK_MAX 100 > #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) > > +/* > + * Properties of EXTCON_TYPE_DISP. > + * > + * - EXTCON_PROP_DISP_HPD You should add the full name of 'HPD'. > + * @type: integer (intval) > + * @value: 0 (no hpd) or 1 (hpd) > + * @default: 0 (no hpd) > + * > + */ > + > +#define EXTCON_PROP_DISP_HPD 150 > + > /* Properties of EXTCON_TYPE_DISP. */ > #define EXTCON_PROP_DISP_MIN 150 > -#define EXTCON_PROP_DISP_MAX 150 > +#define EXTCON_PROP_DISP_MAX 151 > #define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1) > > /* > -- Best Regards, Chanwoo Choi