From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499AbcILCXZ (ORCPT ); Sun, 11 Sep 2016 22:23:25 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55037 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932258AbcILCXY (ORCPT ); Sun, 11 Sep 2016 22:23:24 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79cb6d000006cfe-42-57d61199a9f3 Content-transfer-encoding: 8BIT Message-id: <57D61199.6010807@samsung.com> Date: Mon, 12 Sep 2016 11:23:21 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Chris Zhong , myungjoo.ham@samsung.com, linux@roeck-us.net Cc: linux-kernel@vger.kernel.org, cpgs@samsung.com, groeck@chromium.org Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property References: <1473467630-29675-1-git-send-email-zyw@rock-chips.com> <57D5FEC7.5020509@samsung.com> In-reply-to: <57D5FEC7.5020509@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsWyRsSkQHeW4LVwg5M9TBYvD2lanHq1jNni 8q45bBZPFp5hsrjduILNYv6DHcwObB6zGy6yePydtZ/FY+f3BnaPvi2rGD0+b5ILYI3isklJ zcksSy3St0vgyth87TZLwSqeikVnT7E0MHZydTFyckgImEh0PljOCGGLSVy4t56ti5GLQ0hg BaPEzz/PWGGKju27wQ6RWMooceHHDLAOXgFBiR+T77F0MXJwMAvISxy5lA1hqktMmZILUf6A UaLtbjczRLmWxMmZG5hAbBYBVYnFNz+ygdhsQPH9L26A2fwCihJXfzxmBJkjKhAh0X2iEiQs IhAisfTXVWaI8e4SFyeZg4SFBVwk5rw5xwqxaiejxKKpnWCrOAW0Jf5+msACkpAQuMQu8ebT RFaIvQIS3yYfAjtZQkBWYtMBZogXJSUOrrjBMoFRfBaSx2YhPDYL4bEFjMyrGEVTC5ILipPS i4z0ihNzi0vz0vWS83M3MQJj7/S/Z307GG8esD7EKMDBqMTDW8B+LVyINbGsuDL3EKMp0A0T maVEk/OBEZ5XEm9obGZkYWpiamxkbmmmJM6bIPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwen VANjoXjS4uV7GbOfCKzbeUzTP7BvktenNW+3O5cqXFWrKhD2jJZmy94aeLDkV8xfVivB6yuD fwqW6f7cP2VZc97a5Kn32iZOMJmw+8W/pJnKbgtmHnVevvJpuLau4XveT5Nnb1cRF/qc2cNa k3Dud8mSq/t3r064YnCXqyt7z40PNa9sfj6dvjW8QomlOCPRUIu5qDgRADtTO1K4AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t9jAd2ZgtfCDb7csrR4eUjT4tSrZcwW l3fNYbN4svAMk8XtxhVsFvMf7GB2YPOY3XCRxePvrP0sHju/N7B79G1ZxejxeZNcAGtUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMzddusxSs4qlYdPYUSwNjJ1cXIyeH hICJxLF9N9ghbDGJC/fWs3UxcnEICSxllLjwYwYjSIJXQFDix+R7LF2MHBzMAvISRy5lQ5jq ElOm5EKUP2CUaLvbzQxRriVxcuYGJhCbRUBVYvHNj2wgNhtQfP+LG2A2v4CixNUfjxlB5ogK REh0n6gECYsIhEgs/XWVGWK8u8TFSeYgYWEBF4k5b86xQqzaySixaGon2CpOAW2Jv58msExg FJyF5NBZCIfOQjh0ASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzg+H4mvYPx8C73 Q4wCHIxKPLwXBK6FC7EmlhVX5h5ilOBgVhLhPQQS4k1JrKxKLcqPLyrNSS0+xGgK9OlEZinR 5Hxg6skriTc0NjEzsjQyN7QwMjZXEud9/H9dmJBAemJJanZqakFqEUwfEwenVAPj+jdvLgsV GO/JmhZ+sfXLgtuP3s1Xqbx02bBBx6W1Vq3pRrSeZ8u3YJtfpnWSpor+SkeSL8mUfZZV3V5x Ii7P6lXtVzMO3h9LXbp8jEUO/pSZO23petcZPMV2Wsu/ru5p0mis/+PpLnLz/60ZGRpy3po5 9mq5iytWzBSLnesX9brC1nvbAx0lluKMREMt5qLiRACZJayGBQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 2016년 09월 12일 10:03, Chanwoo Choi wrote: > Hi Chris, > > On 2016년 09월 10일 09:33, Chris Zhong wrote: >> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd >> interrupt, this property can be used. > > What is meaning of HPD? So, you need to add the > description and reference for HPD in commit message. > > For example, > When adding EXTCON_PROP_USB_SS property[1], > the commit message included the reference for USB SuperSpeed. > [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 > >> >> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed > > You have to remove the 'Change-Id'. > >> Signed-off-by: Chris Zhong >> --- >> include/linux/extcon.h | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index 9147c42..4411893 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -131,9 +131,21 @@ >> #define EXTCON_PROP_JACK_MAX 100 >> #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) >> >> +/* >> + * Properties of EXTCON_TYPE_DISP. >> + * >> + * - EXTCON_PROP_DISP_HPD > > You should add the full name of 'HPD'. On previous mail, I replied ambiguous comment. I mean that you better to add the property name with full name as following: EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx) [snip] -- Best Regards, Chanwoo Choi