From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756508AbcILCkU (ORCPT ); Sun, 11 Sep 2016 22:40:20 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56878 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755550AbcILCkT (ORCPT ); Sun, 11 Sep 2016 22:40:19 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79cb6d000006cfe-f4-57d6159035f6 Content-transfer-encoding: 8BIT Message-id: <57D61590.1030307@samsung.com> Date: Mon, 12 Sep 2016 11:40:16 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Guenter Roeck Cc: Chris Zhong , MyungJoo Ham , Guenter Roeck , linux-kernel , "cpgs (cpgs@samsung.com)" , Guenter Roeck Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property References: <1473467630-29675-1-git-send-email-zyw@rock-chips.com> <57D5FEC7.5020509@samsung.com> <57D61199.6010807@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsWyRsSkQHeC6LVwg8mHFS1eHtK0OPVqGbNF 76IlLBaXd81hs3iy8AyTxe3GFWwW8x/sYHZg95jdcJHFY8GmUo+/s/azeOz83sDu0bdlFaPH 501yAWxRXDYpqTmZZalF+nYJXBm7Xz1jLugUqjjx8z5zA+M1vi5GTg4JAROJ1RN3s0DYYhIX 7q1n62Lk4hASWMEo8WvFdiaYojttr1ghErMYJZ5dWsQMkuAVEJT4MfkeUDcHB7OAvMSRS9kQ prrElCm5EOUPGCVuPDzLClGuJTFvQycjiM0ioCrx6P4fMJsNKL7/xQ02EJtfQFHi6o/HjCBz RAUiJLpPVIKERYDKTz09DnYbs8BPRok7R/aC3SYs4CIx5805qNvmM0kcXrEAbBCnQLDErNtz WUASEgIv2SVeT9/BDLFZQOLb5ENgR0sIyEpsOsAM8aSkxMEVN1gmMIrPQvLaLITXZiG8toCR eRWjaGpBckFxUnqRkV5xYm5xaV66XnJ+7iZGYESe/vesbwfjzQPWhxgFOBiVeHgL2K+FC7Em lhVX5h5iNAW6YSKzlGhyPjDu80riDY3NjCxMTUyNjcwtzZTEeROkfgYLCaQnlqRmp6YWpBbF F5XmpBYfYmTi4JRqYHTZ1h0u/lr/SG+W4tu7Z0rdf5iu/ct93E0reOOZ73HqhrPmCSlMOyp5 Y8WmxM5WqRnH9RnXy7WxW2ySqj1ctuBa9bzTrU78q+61r2yfcCOYcUPi88TEFKlzfopRV3f8 KzA7UTnj7v5vrG+kWlqOeVl4Xu67XaUV09p+Nb/8hU3i0b0LogLqDyqxFGckGmoxFxUnAgDf k1nrwwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsVy+t9jQd0JotfCDc7MlrZ4eUjT4tSrZcwW vYuWsFhc3jWHzeLJwjNMFrcbV7BZzH+wg9mB3WN2w0UWjwWbSj3+ztrP4rHzewO7R9+WVYwe nzfJBbBFNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl 5gCdoqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHM2P3qGXNBp1DFiZ/3 mRsYr/F1MXJySAiYSNxpe8UKYYtJXLi3nq2LkYtDSGAWo8SzS4uYQRK8AoISPybfY+li5OBg FpCXOHIpG8JUl5gyJRei/AGjxI2HZ1khyrUk5m3oZASxWQRUJR7d/wNmswHF97+4wQZi8wso Slz98ZgRZI6oQIRE94lKkLAIUPmpp8fBTmAW+MkocefIXiaQhLCAi8ScN+dYIZbNZ5I4vGIB 2CBOgWCJWbfnskxgFJyF5NRZCKfOQjh1ASPzKkaJ1ILkguKk9FzDvNRyveLE3OLSvHS95Pzc TYzgqH8mtYPx4C73Q4wCHIxKPLwOk66GC7EmlhVX5h5ilOBgVhLhPSRwLVyINyWxsiq1KD++ qDQntfgQoynQrxOZpUST84EJKa8k3tDYxMzI0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalF MH1MHJxSDYx7/vk98fv4+0vdjUKREqHzTb6em7w9OPYo8dn/3f93TYj/3gWXFzk5KlR9irrx 9cN6hoWff+478FVlq4tkR8+rLUEvvnyZqGJUv+G53E2R5xWv4rkYHlqucl/ZLRg1l3OljFH1 fTWVTF+5eReCdxlvf668cvMDrVeiinOZtjtlXd5R3ze34bqQEktxRqKhFnNRcSIA3F+lpRAD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On 2016년 09월 12일 11:29, Guenter Roeck wrote: > On Sun, Sep 11, 2016 at 7:23 PM, Chanwoo Choi wrote: >> Hi Chris, >> >> On 2016년 09월 12일 10:03, Chanwoo Choi wrote: >>> Hi Chris, >>> >>> On 2016년 09월 10일 09:33, Chris Zhong wrote: >>>> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd >>>> interrupt, this property can be used. >>> >>> What is meaning of HPD? So, you need to add the >>> description and reference for HPD in commit message. >>> >>> For example, >>> When adding EXTCON_PROP_USB_SS property[1], >>> the commit message included the reference for USB SuperSpeed. >>> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 >>> >>>> >>>> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed >>> >>> You have to remove the 'Change-Id'. >>> >>>> Signed-off-by: Chris Zhong >>>> --- >>>> include/linux/extcon.h | 14 +++++++++++++- >>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>>> index 9147c42..4411893 100644 >>>> --- a/include/linux/extcon.h >>>> +++ b/include/linux/extcon.h >>>> @@ -131,9 +131,21 @@ >>>> #define EXTCON_PROP_JACK_MAX 100 >>>> #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) >>>> >>>> +/* >>>> + * Properties of EXTCON_TYPE_DISP. >>>> + * >>>> + * - EXTCON_PROP_DISP_HPD >>> >>> You should add the full name of 'HPD'. >> >> On previous mail, I replied ambiguous comment. >> >> I mean that you better to add the property name with full name as following: >> >> EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx) > > What do you prefer ? > > HOTPLUGDETECT ? HOT_PLUG_DETECT ? HOTPLUG_DETECT ? I prefer to add 'HPD (Hot Plug Detect)'. > > The term "HPD" seems to be quite common in the DisplayPort world; in > most presentations it isn't even explained. Personally I would prefer > to stick with HPD and explain it in the comments. People who are unfamiliar with DisplayPort world need the explanation and full name of HPD. Basically, all abbreviation should show the full name. -- Best Regards, Chanwoo Choi