* [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property @ 2016-09-10 0:33 ` Chris Zhong 2016-09-10 3:07 ` Guenter Roeck 2016-09-12 1:03 ` Chanwoo Choi 0 siblings, 2 replies; 6+ messages in thread From: Chris Zhong @ 2016-09-10 0:33 UTC (permalink / raw) To: myungjoo.ham, linux, cw00.choi; +Cc: linux-kernel, cpgs, groeck, Chris Zhong EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd interrupt, this property can be used. Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed Signed-off-by: Chris Zhong <zyw@rock-chips.com> --- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/include/linux/extcon.h b/include/linux/extcon.h index 9147c42..4411893 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -131,9 +131,21 @@ #define EXTCON_PROP_JACK_MAX 100 #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) +/* + * Properties of EXTCON_TYPE_DISP. + * + * - EXTCON_PROP_DISP_HPD + * @type: integer (intval) + * @value: 0 (no hpd) or 1 (hpd) + * @default: 0 (no hpd) + * + */ + +#define EXTCON_PROP_DISP_HPD 150 + /* Properties of EXTCON_TYPE_DISP. */ #define EXTCON_PROP_DISP_MIN 150 -#define EXTCON_PROP_DISP_MAX 150 +#define EXTCON_PROP_DISP_MAX 151 #define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1) /* -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property 2016-09-10 0:33 ` [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property Chris Zhong @ 2016-09-10 3:07 ` Guenter Roeck 2016-09-12 1:03 ` Chanwoo Choi 1 sibling, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2016-09-10 3:07 UTC (permalink / raw) To: Chris Zhong, myungjoo.ham, cw00.choi; +Cc: linux-kernel, cpgs, groeck On 09/09/2016 05:33 PM, Chris Zhong wrote: > EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd > interrupt, this property can be used. > > Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed Drop Change-ID: for upstream submissions. > Signed-off-by: Chris Zhong <zyw@rock-chips.com> Otherwise, yes, looks like this is needed. Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > include/linux/extcon.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index 9147c42..4411893 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -131,9 +131,21 @@ > #define EXTCON_PROP_JACK_MAX 100 > #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) > > +/* > + * Properties of EXTCON_TYPE_DISP. > + * > + * - EXTCON_PROP_DISP_HPD > + * @type: integer (intval) > + * @value: 0 (no hpd) or 1 (hpd) > + * @default: 0 (no hpd) > + * > + */ > + > +#define EXTCON_PROP_DISP_HPD 150 > + > /* Properties of EXTCON_TYPE_DISP. */ > #define EXTCON_PROP_DISP_MIN 150 > -#define EXTCON_PROP_DISP_MAX 150 > +#define EXTCON_PROP_DISP_MAX 151 > #define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1) > > /* > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property 2016-09-10 0:33 ` [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property Chris Zhong 2016-09-10 3:07 ` Guenter Roeck @ 2016-09-12 1:03 ` Chanwoo Choi 2016-09-12 2:23 ` Chanwoo Choi 1 sibling, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2016-09-12 1:03 UTC (permalink / raw) To: Chris Zhong, myungjoo.ham, linux; +Cc: linux-kernel, cpgs, groeck Hi Chris, On 2016년 09월 10일 09:33, Chris Zhong wrote: > EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd > interrupt, this property can be used. What is meaning of HPD? So, you need to add the description and reference for HPD in commit message. For example, When adding EXTCON_PROP_USB_SS property[1], the commit message included the reference for USB SuperSpeed. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 > > Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed You have to remove the 'Change-Id'. > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > --- > include/linux/extcon.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index 9147c42..4411893 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -131,9 +131,21 @@ > #define EXTCON_PROP_JACK_MAX 100 > #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) > > +/* > + * Properties of EXTCON_TYPE_DISP. > + * > + * - EXTCON_PROP_DISP_HPD You should add the full name of 'HPD'. > + * @type: integer (intval) > + * @value: 0 (no hpd) or 1 (hpd) > + * @default: 0 (no hpd) > + * > + */ > + > +#define EXTCON_PROP_DISP_HPD 150 > + > /* Properties of EXTCON_TYPE_DISP. */ > #define EXTCON_PROP_DISP_MIN 150 > -#define EXTCON_PROP_DISP_MAX 150 > +#define EXTCON_PROP_DISP_MAX 151 > #define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1) > > /* > -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property 2016-09-12 1:03 ` Chanwoo Choi @ 2016-09-12 2:23 ` Chanwoo Choi 2016-09-12 2:29 ` Guenter Roeck 0 siblings, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2016-09-12 2:23 UTC (permalink / raw) To: Chris Zhong, myungjoo.ham, linux; +Cc: linux-kernel, cpgs, groeck Hi Chris, On 2016년 09월 12일 10:03, Chanwoo Choi wrote: > Hi Chris, > > On 2016년 09월 10일 09:33, Chris Zhong wrote: >> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd >> interrupt, this property can be used. > > What is meaning of HPD? So, you need to add the > description and reference for HPD in commit message. > > For example, > When adding EXTCON_PROP_USB_SS property[1], > the commit message included the reference for USB SuperSpeed. > [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 > >> >> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed > > You have to remove the 'Change-Id'. > >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> --- >> include/linux/extcon.h | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index 9147c42..4411893 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -131,9 +131,21 @@ >> #define EXTCON_PROP_JACK_MAX 100 >> #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) >> >> +/* >> + * Properties of EXTCON_TYPE_DISP. >> + * >> + * - EXTCON_PROP_DISP_HPD > > You should add the full name of 'HPD'. On previous mail, I replied ambiguous comment. I mean that you better to add the property name with full name as following: EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx) [snip] -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property 2016-09-12 2:23 ` Chanwoo Choi @ 2016-09-12 2:29 ` Guenter Roeck 2016-09-12 2:40 ` Chanwoo Choi 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2016-09-12 2:29 UTC (permalink / raw) To: Chanwoo Choi Cc: Chris Zhong, MyungJoo Ham, Guenter Roeck, linux-kernel, cpgs (cpgs@samsung.com), Guenter Roeck On Sun, Sep 11, 2016 at 7:23 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Chris, > > On 2016년 09월 12일 10:03, Chanwoo Choi wrote: >> Hi Chris, >> >> On 2016년 09월 10일 09:33, Chris Zhong wrote: >>> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd >>> interrupt, this property can be used. >> >> What is meaning of HPD? So, you need to add the >> description and reference for HPD in commit message. >> >> For example, >> When adding EXTCON_PROP_USB_SS property[1], >> the commit message included the reference for USB SuperSpeed. >> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 >> >>> >>> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed >> >> You have to remove the 'Change-Id'. >> >>> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >>> --- >>> include/linux/extcon.h | 14 +++++++++++++- >>> 1 file changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>> index 9147c42..4411893 100644 >>> --- a/include/linux/extcon.h >>> +++ b/include/linux/extcon.h >>> @@ -131,9 +131,21 @@ >>> #define EXTCON_PROP_JACK_MAX 100 >>> #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) >>> >>> +/* >>> + * Properties of EXTCON_TYPE_DISP. >>> + * >>> + * - EXTCON_PROP_DISP_HPD >> >> You should add the full name of 'HPD'. > > On previous mail, I replied ambiguous comment. > > I mean that you better to add the property name with full name as following: > > EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx) What do you prefer ? HOTPLUGDETECT ? HOT_PLUG_DETECT ? HOTPLUG_DETECT ? The term "HPD" seems to be quite common in the DisplayPort world; in most presentations it isn't even explained. Personally I would prefer to stick with HPD and explain it in the comments. Guenter > > [snip] > > -- > Best Regards, > Chanwoo Choi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property 2016-09-12 2:29 ` Guenter Roeck @ 2016-09-12 2:40 ` Chanwoo Choi 0 siblings, 0 replies; 6+ messages in thread From: Chanwoo Choi @ 2016-09-12 2:40 UTC (permalink / raw) To: Guenter Roeck Cc: Chris Zhong, MyungJoo Ham, Guenter Roeck, linux-kernel, cpgs (cpgs@samsung.com), Guenter Roeck Hi Guenter, On 2016년 09월 12일 11:29, Guenter Roeck wrote: > On Sun, Sep 11, 2016 at 7:23 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi Chris, >> >> On 2016년 09월 12일 10:03, Chanwoo Choi wrote: >>> Hi Chris, >>> >>> On 2016년 09월 10일 09:33, Chris Zhong wrote: >>>> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd >>>> interrupt, this property can be used. >>> >>> What is meaning of HPD? So, you need to add the >>> description and reference for HPD in commit message. >>> >>> For example, >>> When adding EXTCON_PROP_USB_SS property[1], >>> the commit message included the reference for USB SuperSpeed. >>> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610 >>> >>>> >>>> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed >>> >>> You have to remove the 'Change-Id'. >>> >>>> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >>>> --- >>>> include/linux/extcon.h | 14 +++++++++++++- >>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>>> index 9147c42..4411893 100644 >>>> --- a/include/linux/extcon.h >>>> +++ b/include/linux/extcon.h >>>> @@ -131,9 +131,21 @@ >>>> #define EXTCON_PROP_JACK_MAX 100 >>>> #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) >>>> >>>> +/* >>>> + * Properties of EXTCON_TYPE_DISP. >>>> + * >>>> + * - EXTCON_PROP_DISP_HPD >>> >>> You should add the full name of 'HPD'. >> >> On previous mail, I replied ambiguous comment. >> >> I mean that you better to add the property name with full name as following: >> >> EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx) > > What do you prefer ? > > HOTPLUGDETECT ? HOT_PLUG_DETECT ? HOTPLUG_DETECT ? I prefer to add 'HPD (Hot Plug Detect)'. > > The term "HPD" seems to be quite common in the DisplayPort world; in > most presentations it isn't even explained. Personally I would prefer > to stick with HPD and explain it in the comments. People who are unfamiliar with DisplayPort world need the explanation and full name of HPD. Basically, all abbreviation should show the full name. -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-12 2:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160910003427epcas1p24ea63646e269802afb56104fd9096471@epcas1p2.samsung.com>
2016-09-10 0:33 ` [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property Chris Zhong
2016-09-10 3:07 ` Guenter Roeck
2016-09-12 1:03 ` Chanwoo Choi
2016-09-12 2:23 ` Chanwoo Choi
2016-09-12 2:29 ` Guenter Roeck
2016-09-12 2:40 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox