From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757175AbcILItY (ORCPT ); Mon, 12 Sep 2016 04:49:24 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50177 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcILItW (ORCPT ); Mon, 12 Sep 2016 04:49:22 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org EBACA6120C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm: msm: mdp4: mark symbols static where possible To: Baoyou Xie , robdclark@gmail.com References: <1473245924-655-1-git-send-email-baoyou.xie@linaro.org> Cc: airlied@linux.ie, daniel.vetter@ffwll.ch, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, daniels@collabora.com, maarten.lankhorst@linux.intel.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Archit Taneja Message-ID: <57D66C08.4000206@codeaurora.org> Date: Mon, 12 Sep 2016 14:19:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1473245924-655-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2016 04:28 PM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c:96:23: warning: no previous prototype for 'get_connector' [-Wmissing-prototypes] > drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c:84:5: warning: no previous prototype for 'mdp4_plane_set_property' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. Reviewed-by: Archit Taneja > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 2 +- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c > index bc3d8e7..a06b064 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c > @@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = { > }; > > /* this should probably be a helper: */ > -struct drm_connector *get_connector(struct drm_encoder *encoder) > +static struct drm_connector *get_connector(struct drm_encoder *encoder) > { > struct drm_device *dev = encoder->dev; > struct drm_connector *connector; > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c > index 9f96dfe..c5adef0 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c > @@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane, > // XXX > } > > -int mdp4_plane_set_property(struct drm_plane *plane, > +static int mdp4_plane_set_property(struct drm_plane *plane, > struct drm_property *property, uint64_t val) > { > // XXX > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project