From: Deepak <deepak_das@mentor.com>
To: <linus.walleij@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
vzapolsk <Vladimir_Zapolskiy@mentor.com>
Subject: [PATCH] driver: base: pinctrl: return error from pinctrl_bind_pins()
Date: Tue, 13 Sep 2016 12:43:04 +0530 [thread overview]
Message-ID: <57D7A700.8080402@mentor.com> (raw)
strict pin controller returns -EINVAL in case of pin request which
is already claimed by somebody else.
Following is the sequence of calling pin_request() from
pinctrl_bind_pins():-
pinctrl_bind_pins()->pinctrl_select_state()->pinmux_enable_setting()->
pin_request()
But pinctrl_bind_pins() only returns -EPROBE_DEFER which makes device
driver probe successful even if the pin request is rejected by the pin
controller subsystem.
This commit modifies pinctrl_bind_pins() to return error if the pin is
rejected by pin control subsystem.
Signed-off-by: Deepak Das <deepak_das@mentor.com>
---
drivers/base/pinctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/pinctrl.c b/drivers/base/pinctrl.c
index 0762975..e65c1af 100644
--- a/drivers/base/pinctrl.c
+++ b/drivers/base/pinctrl.c
@@ -92,7 +92,7 @@ cleanup_alloc:
dev->pins = NULL;
/* Only return deferrals */
- if (ret != -EPROBE_DEFER)
+ if ((ret != -EPROBE_DEFER) && (ret != -EINVAL))
ret = 0;
return ret;
--
1.9.1
next reply other threads:[~2016-09-13 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:13 Deepak [this message]
2016-09-13 11:59 ` [PATCH] driver: base: pinctrl: return error from pinctrl_bind_pins() Linus Walleij
2016-09-13 13:41 ` Deepak Das
2016-09-13 21:01 ` Linus Walleij
2016-09-14 6:22 ` Deepak Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D7A700.8080402@mentor.com \
--to=deepak_das@mentor.com \
--cc=Vladimir_Zapolskiy@mentor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox