From: Marc Zyngier <marc.zyngier@arm.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org, stable@kernel.vger.org
Subject: Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()
Date: Tue, 13 Sep 2016 13:21:28 +0100 [thread overview]
Message-ID: <57D7EF48.3070807@arm.com> (raw)
In-Reply-To: <20160913132348.00518d16@bbrezillon>
On 13/09/16 12:23, Boris Brezillon wrote:
> On Tue, 13 Sep 2016 12:10:09 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
>> aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip
>> lock without disabling interrupts, which can lead to a deadlock if an
>> interrupt occurs while the lock is held in one of these functions.
>>
>> Replace irq_gc_{lock,unlock}() calls by
>> raw_spin_{lock_irqsave,unlock_irqrestore}() ones to prevent this bug from
>> happening.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
>> Cc: <stable@kernel.vger.org>
>
> Oops, should be
>
> Cc: <stable@vger.kernel.org>
>
> Do you want me to send a v2?
You might as well, so that tglx can pick the patch with my ack on it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-09-13 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 10:10 [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate() Boris Brezillon
2016-09-13 10:12 ` Boris Brezillon
2016-09-13 10:28 ` Marc Zyngier
2016-09-13 11:23 ` Boris Brezillon
2016-09-13 12:21 ` Marc Zyngier [this message]
2016-09-13 12:55 ` Thomas Gleixner
2016-09-13 13:00 ` Boris Brezillon
2016-09-13 13:13 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D7EF48.3070807@arm.com \
--to=marc.zyngier@arm.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@kernel.vger.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox