From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755265AbcIMMVd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 08:21:33 -0400
Received: from foss.arm.com ([217.140.101.70]:47364 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752643AbcIMMVc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 08:21:32 -0400
Subject: Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
References: <1473761409-16226-1-git-send-email-boris.brezillon@free-electrons.com>
 <20160913132348.00518d16@bbrezillon>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        linux-kernel@vger.kernel.org, stable@kernel.vger.org
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <57D7EF48.3070807@arm.com>
Date: Tue, 13 Sep 2016 13:21:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <20160913132348.00518d16@bbrezillon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/09/16 12:23, Boris Brezillon wrote:
> On Tue, 13 Sep 2016 12:10:09 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
>> aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip
>> lock without disabling interrupts, which can lead to a deadlock if an
>> interrupt occurs while the lock is held in one of these functions.
>>
>> Replace irq_gc_{lock,unlock}() calls by
>> raw_spin_{lock_irqsave,unlock_irqrestore}() ones to prevent this bug from
>> happening.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
>> Cc: <stable@kernel.vger.org>
> 
> Oops, should be
> 
> Cc: <stable@vger.kernel.org>
> 
> Do you want me to send a v2?

You might as well, so that tglx can pick the patch with my ack on it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...